T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove FPR32; fixes #1303

Browse Source 
Until #1306 is resolved (some spilling/regalloc issue with larger FPR register banks), this removes FPR32 support. Only Wasm's `i64x2.mul` was using this register class and that instruction is predicated on AVX512 support; for the time being, that instruction will have to make do with the 16 FPR registers.
This commit is contained in:
Andrew Brown
2020-03-13 14:54:23 -07:00
parent af709ded94
commit 8598295bc4
6 changed files with 34 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
crates/jit/src/compiler.rs
View File

@@ -166,14 +166,11 @@ impl Compiler {
if trampolines.contains_key(&index) {
continue;
}
// FIXME(#1303) we should be generating a trampoline for all
// FIXME(#1322) we should be generating a trampoline for all
// functions in a module, not just those with less than 40
// arguments. Currently though cranelift dies in spec tests when one
// function has 100 arguments. This looks to be a cranelift bug, so
// let's work around it for now by skipping generating a trampoline
// for that massive function. The trampoline isn't actually needed
// at this time, and we'll hopefully get the cranelift bug fixed
// soon enough to remove this condition.
// arguments. Currently there is no relocation support for
// trampoline compilation; when that is added this check can
// go away.
if sig.params.len() > 40 {
continue;
}