T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

can't put tracing behind a feature without an extra crate :(

Browse Source
This commit is contained in:
Pat Hickey
2020-06-02 15:56:13 -07:00
parent 02c0c68ed2
commit 820b283cf8
3 changed files with 5 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
crates/wiggle/Cargo.toml
View File

@@ -14,7 +14,7 @@ include = ["src/**/*", "LICENSE"]
thiserror = "1"
witx = { path = "../wasi-common/WASI/tools/witx", version = "0.8.5", optional = true }
wiggle-macro = { path = "macro", version = "0.17.0" }
tracing_crate = { version = "0.1.14", optional = true, package = "tracing" }
tracing = { version = "0.1.14" }
[badges]
maintenance = { status = "actively-developed" }
@@ -29,9 +29,5 @@ proptest = "0.9"
# users of wiggle are not forced to take a direct dependency on the `witx`
# crate unless they want it.
wiggle_metadata = ['witx', "wiggle-macro/wiggle_metadata"]
# The wiggle proc-macro emits code which may transitively depend on the
# `tracing` crate, via `wiggle::tracing`. When this feature is not enabled,
# a no-op equivelant to the tracing macros is provided instead.
tracing = [ "tracing_crate" ]
default = ["wiggle_metadata", "tracing"]
default = ["wiggle_metadata" ]

4
crates/wiggle/src/lib.rs
View File

@@ -15,7 +15,9 @@ mod borrow;
mod error;
mod guest_type;
mod region;
pub mod tracing;
pub mod tracing {
pub use tracing::*;
}
pub use borrow::BorrowChecker;
use borrow::BorrowHandle;

11
crates/wiggle/src/tracing.rs
View File

@@ -1,11 +0,0 @@
#[cfg(feature = "tracing")]
pub use tracing_crate::*;
#[cfg(not(feature = "tracing"))]
mod noop_tracing {
// TODO fill in rest of the noop interface
// idk how to do this because macro_rules! / #[macro_export] doesn't follow the usual module
// visibility rules.
}
#[cfg(not(feature = "tracing"))]
pub use noop_tracing::*;