Return EINVAL in poll_oneoff with no events. (#838)

* Return EINVAL in poll_oneoff with no events.

We adhere to WebAssembly/WASI#193.

* Add a test for empty poll.
This commit is contained in:
Marcin Mielniczuk
2020-01-17 22:41:37 +01:00
committed by Dan Gohman
parent 448faed5ca
commit 815576edc5
2 changed files with 22 additions and 0 deletions

View File

@@ -19,6 +19,18 @@ unsafe fn poll_oneoff_impl(r#in: &[wasi::Subscription], nexpected: usize) -> Vec
out
}
unsafe fn test_empty_poll() {
let r#in = [];
let mut out: Vec<wasi::Event> = Vec::new();
let error = wasi::poll_oneoff(r#in.as_ptr(), out.as_mut_ptr(), r#in.len())
.expect_err("empty poll_oneoff should fail");
assert_eq!(
error.raw_error(),
wasi::ERRNO_INVAL,
"error should be EINVAL"
);
}
unsafe fn test_timeout() {
let clock = wasi::SubscriptionClock {
id: wasi::CLOCKID_MONOTONIC,
@@ -220,6 +232,7 @@ unsafe fn test_fd_readwrite_invalid_fd() {
unsafe fn test_poll_oneoff(dir_fd: wasi::Fd) {
test_timeout();
test_empty_poll();
// NB we assume that stdin/stdout/stderr are valid and open
// for the duration of the test case
test_stdin_read();