From 8127346b4d7cc741624483041fd9925438562be3 Mon Sep 17 00:00:00 2001 From: Alex Crichton Date: Thu, 27 May 2021 11:08:19 -0500 Subject: [PATCH] ci: Use something else for zip files on Windows (#2941) Apparently `powershell Compress-Archive` produces zip files with backslashes in filesnames which makes them unable to be extracted with some Unix variants of extraction. For example [this failure][build] and using macOS's built-in unzip feature it creates filenames with backslashes in them rather than subdirectories. [build]: https://github.com/bytecodealliance/wasmtime-go/runs/2680596219?check_suite_focus=true --- ci/build-tarballs.sh | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/ci/build-tarballs.sh b/ci/build-tarballs.sh index c3f73af635..70a8858d72 100755 --- a/ci/build-tarballs.sh +++ b/ci/build-tarballs.sh @@ -76,9 +76,8 @@ mktarball() { tar -cvf - -C tmp $dir | xz -9 -T0 > dist/$dir.tar.xz else # Note that this runs on Windows, and it looks like GitHub Actions doesn't - # have a `zip` tool there, so we use powershell - (cd tmp && powershell Compress-Archive $dir $dir.zip) - mv tmp/$dir.zip dist + # have a `zip` tool there, so we use something else + (cd tmp && 7z a ../dist/$dir.zip $dir/) fi }