T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid cloning an InstructionData when it isn't needed.

Browse Source
This commit is contained in:
Dan Gohman
2018-11-09 15:13:42 -08:00
parent a0c2b40c17
commit 7b27fdbf54
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lib/codegen/src/simple_gvn.rs
View File

@@ -110,10 +110,8 @@ pub fn do_simple_gvn(func: &mut Function, domtree: &mut DominatorTree) {
continue; continue;
} }
let inst_data = func.dfg[inst].clone();
// These are split up to separate concerns. // These are split up to separate concerns.
if is_load_and_not_readonly(&inst_data) { if is_load_and_not_readonly(&func.dfg[inst]) {
continue; continue;
} }
@@ -123,9 +121,8 @@ pub fn do_simple_gvn(func: &mut Function, domtree: &mut DominatorTree) {
ty: ctrl_typevar, ty: ctrl_typevar,
pos: &pos, pos: &pos,
}; };
let entry = visible_values.entry(key);
use scoped_hash_map::Entry::*; use scoped_hash_map::Entry::*;
match entry { match visible_values.entry(key) {
Occupied(entry) => { Occupied(entry) => {
debug_assert!(domtree.dominates(*entry.get(), inst, &func.layout)); debug_assert!(domtree.dominates(*entry.get(), inst, &func.layout));
// If the redundant instruction is representing the current // If the redundant instruction is representing the current