T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Code review feedback.

Browse Source 
* Improve comments.
* Drop old table element *after* updating the table.
* Extract out the same `cfg_if!` to a single constant.
This commit is contained in:
Peter Huene
2021-03-08 09:04:13 -08:00
parent 8e51aefb2c
commit 7a93132ffa
4 changed files with 19 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
crates/runtime/src/table.rs
View File

@@ -372,11 +372,13 @@ impl Table {
}
}
fn set_raw(ty: TableElementType, e: &mut *mut u8, val: TableElement) {
fn set_raw(ty: TableElementType, elem: &mut *mut u8, val: TableElement) {
unsafe {
// Drop the existing element
let _ = TableElement::from_raw(ty, *e);
*e = val.into_raw();
let old = *elem;
*elem = val.into_raw();
// Drop the old element
let _ = TableElement::from_raw(ty, old);
}
}