Don't perform gvn on instructions with other_side_effects().

2017-08-08 14:14:59 -07:00
parent 8546cabc8f
commit 79d8aa366d
2 changed files with 12 additions and 1 deletions
--- a/lib/cretonne/src/simple_gvn.rs
+++ b/lib/cretonne/src/simple_gvn.rs
@@ -8,7 +8,7 @@ use std::collections::HashMap;
 /// Test whether the given opcode is unsafe to even consider for GVN.
 fn trivially_unsafe_for_gvn(opcode: Opcode) -> bool {
    opcode.is_call() || opcode.is_branch() || opcode.is_terminator() || opcode.is_return() ||
-    opcode.can_trap()
+    opcode.can_trap() || opcode.other_side_effects()
 }

 /// Perform simple GVN on `func`.