Change CLIF shuffle to validate lane indices (#5995)
* Change CLIF `shuffle` to validate lane indices Previously the CLIF `shuffle` instruction did not perform any validation on the lane shuffle mask and specified that out-of-bounds lanes always returned 0 as the value. This behavior though is not required by WebAssembly which validates that lane indices are always in-bounds. Additionally since these are static immediates even other code generators should be able to verify that the immediates are in-bounds. As a result this commit updates the definition of the `shuffle` instruction to specify that all byte immediates must be in-bounds in the range of [0, 32). The verifier has been updated and some test cases have been removed that were testing this functionality. Closes #5989 * Only generate valid shuffle immediates in fuzzer
This commit is contained in:
@@ -1422,7 +1422,7 @@ pub(crate) fn define(
|
||||
Shuffle two vectors using the given immediate bytes. For each of the 16 bytes of the
|
||||
immediate, a value i of 0-15 selects the i-th element of the first vector and a value i of
|
||||
16-31 selects the (i-16)th element of the second vector. Immediate values outside of the
|
||||
0-31 range place a 0 in the resulting vector lane.
|
||||
0-31 range are not valid.
|
||||
"#,
|
||||
&formats.shuffle,
|
||||
)
|
||||
|
||||
Reference in New Issue
Block a user