Remove the module linking implementation in Wasmtime (#3958)

* Remove the module linking implementation in Wasmtime

This commit removes the experimental implementation of the module
linking WebAssembly proposal from Wasmtime. The module linking is no
longer intended for core WebAssembly but is instead incorporated into
the component model now at this point. This means that very large parts
of Wasmtime's implementation of module linking are no longer applicable
and would change greatly with an implementation of the component model.

The main purpose of this is to remove Wasmtime's reliance on the support
for module-linking in `wasmparser` and tooling crates. With this
reliance removed we can move over to the `component-model` branch of
`wasmparser` and use the updated support for the component model.
Additionally given the trajectory of the component model proposal the
embedding API of Wasmtime will not look like what it looks like today
for WebAssembly. For example the core wasm `Instance` will not change
and instead a `Component` is likely to be added instead.

Some more rationale for this is in #3941, but the basic idea is that I
feel that it's not going to be viable to develop support for the
component model on a non-`main` branch of Wasmtime. Additionaly I don't
think it's viable, for the same reasons as `wasm-tools`, to support the
old module linking proposal and the new component model at the same
time.

This commit takes a moment to not only delete the existing module
linking implementation but some abstractions are also simplified. For
example module serialization is a bit simpler that there's only one
module. Additionally instantiation is much simpler since the only
initializer we have to deal with are imports and nothing else.

Closes #3941

* Fix doc link

* Update comments

crates/c-api/src/extern.rs

@@ -1,9 +1,9 @@
 use crate::{
-    wasm_externkind_t, wasm_externtype_t, wasm_func_t, wasm_global_t, wasm_instance_t,
-    wasm_memory_t, wasm_module_t, wasm_table_t, wasmtime_module_t, CStoreContext, StoreRef,
+    wasm_externkind_t, wasm_externtype_t, wasm_func_t, wasm_global_t, wasm_memory_t, wasm_table_t,
+    CStoreContext, StoreRef,
 };
 use std::mem::ManuallyDrop;
-use wasmtime::{Extern, Func, Global, Instance, Memory, Table};
+use wasmtime::{Extern, Func, Global, Memory, Table};
 
 #[derive(Clone)]
 pub struct wasm_extern_t {
@@ -20,8 +20,6 @@ pub extern "C" fn wasm_extern_kind(e: &wasm_extern_t) -> wasm_externkind_t {
         Extern::Global(_) => crate::WASM_EXTERN_GLOBAL,
         Extern::Table(_) => crate::WASM_EXTERN_TABLE,
         Extern::Memory(_) => crate::WASM_EXTERN_MEMORY,
-        Extern::Instance(_) => crate::WASM_EXTERN_INSTANCE,
-        Extern::Module(_) => crate::WASM_EXTERN_MODULE,
     }
 }
 
@@ -70,26 +68,6 @@ pub extern "C" fn wasm_extern_as_memory_const(e: &wasm_extern_t) -> Option<&wasm
     wasm_extern_as_memory(e)
 }
 
-#[no_mangle]
-pub extern "C" fn wasm_extern_as_module(e: &wasm_extern_t) -> Option<&wasm_module_t> {
-    wasm_module_t::try_from(e)
-}
-
-#[no_mangle]
-pub extern "C" fn wasm_extern_as_module_const(e: &wasm_extern_t) -> Option<&wasm_module_t> {
-    wasm_extern_as_module(e)
-}
-
-#[no_mangle]
-pub extern "C" fn wasm_extern_as_instance(e: &wasm_extern_t) -> Option<&wasm_instance_t> {
-    wasm_instance_t::try_from(e)
-}
-
-#[no_mangle]
-pub extern "C" fn wasm_extern_as_instance_const(e: &wasm_extern_t) -> Option<&wasm_instance_t> {
-    wasm_extern_as_instance(e)
-}
-
 #[repr(C)]
 pub struct wasmtime_extern_t {
     pub kind: wasmtime_extern_kind_t,
@@ -101,17 +79,13 @@ pub const WASMTIME_EXTERN_FUNC: wasmtime_extern_kind_t = 0;
 pub const WASMTIME_EXTERN_GLOBAL: wasmtime_extern_kind_t = 1;
 pub const WASMTIME_EXTERN_TABLE: wasmtime_extern_kind_t = 2;
 pub const WASMTIME_EXTERN_MEMORY: wasmtime_extern_kind_t = 3;
-pub const WASMTIME_EXTERN_INSTANCE: wasmtime_extern_kind_t = 4;
-pub const WASMTIME_EXTERN_MODULE: wasmtime_extern_kind_t = 5;
 
 #[repr(C)]
 pub union wasmtime_extern_union {
     pub func: Func,
     pub table: Table,
     pub global: Global,
-    pub instance: Instance,
     pub memory: Memory,
-    pub module: ManuallyDrop<Box<wasmtime_module_t>>,
 }
 
 impl wasmtime_extern_t {
@@ -121,8 +95,6 @@ impl wasmtime_extern_t {
             WASMTIME_EXTERN_GLOBAL => Extern::Global(self.of.global),
             WASMTIME_EXTERN_TABLE => Extern::Table(self.of.table),
             WASMTIME_EXTERN_MEMORY => Extern::Memory(self.of.memory),
-            WASMTIME_EXTERN_INSTANCE => Extern::Instance(self.of.instance),
-            WASMTIME_EXTERN_MODULE => Extern::Module(self.of.module.module.clone()),
             other => panic!("unknown wasm_extern_kind_t: {}", other),
         }
     }
@@ -147,26 +119,6 @@ impl From<Extern> for wasmtime_extern_t {
                 kind: WASMTIME_EXTERN_MEMORY,
                 of: wasmtime_extern_union { memory },
             },
-            Extern::Instance(instance) => wasmtime_extern_t {
-                kind: WASMTIME_EXTERN_INSTANCE,
-                of: wasmtime_extern_union { instance },
-            },
-            Extern::Module(module) => wasmtime_extern_t {
-                kind: WASMTIME_EXTERN_MODULE,
-                of: wasmtime_extern_union {
-                    module: ManuallyDrop::new(Box::new(wasmtime_module_t { module })),
-                },
-            },
-        }
-    }
-}
-
-impl Drop for wasmtime_extern_t {
-    fn drop(&mut self) {
-        if self.kind == WASMTIME_EXTERN_MODULE {
-            unsafe {
-                ManuallyDrop::drop(&mut self.of.module);
-            }
         }
     }
 }