From 7669a96179f8dc9981106782e0a2f91369b9abf3 Mon Sep 17 00:00:00 2001 From: Alex Crichton Date: Thu, 20 Oct 2022 23:11:38 -0500 Subject: [PATCH] Reduce warnings on CI from GitHub Actions (#5083) * Upgrade our github actions to "node16" Each github actions run has a lot of warnings about using node12 so this upgrades our repository to using node16. I'm hoping no other changes are needed and I suspect other actions we're using are on node12 and will need further updates, but this should help pin down what's remaining. * Update `actions/checkout` workflow to `v3` * Update to `actions/cache@v3` * Update to `actions/upload-artifact@v3` * Drop usage of `actions-rs/toolchain` * Update to `actions/setup-python@v4` * Update mdbook version --- .../binary-compatible-builds/action.yml | 2 +- .github/actions/github-release/action.yml | 2 +- .github/actions/install-rust/action.yml | 2 +- .github/workflows/cargo-audit.yml | 2 +- .github/workflows/main.yml | 40 +++++++++---------- .github/workflows/performance.yml | 8 +--- .github/workflows/publish-to-cratesio.yml | 2 +- .github/workflows/push-tag.yml | 2 +- .github/workflows/release-process.yml | 2 +- 9 files changed, 29 insertions(+), 33 deletions(-) diff --git a/.github/actions/binary-compatible-builds/action.yml b/.github/actions/binary-compatible-builds/action.yml index c2950d99b0..b5a190c4a0 100644 --- a/.github/actions/binary-compatible-builds/action.yml +++ b/.github/actions/binary-compatible-builds/action.yml @@ -2,7 +2,7 @@ name: 'Set up a CentOS 6 container to build releases in' description: 'Set up a CentOS 6 container to build releases in' runs: - using: node12 + using: node16 main: 'main.js' inputs: name: diff --git a/.github/actions/github-release/action.yml b/.github/actions/github-release/action.yml index 3225a91dbb..17c4715b9c 100644 --- a/.github/actions/github-release/action.yml +++ b/.github/actions/github-release/action.yml @@ -8,5 +8,5 @@ inputs: description: '' required: true runs: - using: 'node12' + using: 'node16' main: 'main.js' diff --git a/.github/actions/install-rust/action.yml b/.github/actions/install-rust/action.yml index 7a19659184..6afc01d6f2 100644 --- a/.github/actions/install-rust/action.yml +++ b/.github/actions/install-rust/action.yml @@ -8,5 +8,5 @@ inputs: default: 'stable' runs: - using: node12 + using: node16 main: 'main.js' diff --git a/.github/workflows/cargo-audit.yml b/.github/workflows/cargo-audit.yml index 4c24d366c8..951fe2ca67 100644 --- a/.github/workflows/cargo-audit.yml +++ b/.github/workflows/cargo-audit.yml @@ -6,7 +6,7 @@ jobs: security_audit: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: submodules: true - uses: actions-rs/audit-check@v1 diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index a3c05f9990..ab003114e8 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -21,7 +21,7 @@ jobs: name: Rustfmt runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: submodules: true - uses: ./.github/actions/install-rust @@ -34,7 +34,7 @@ jobs: name: Cargo deny runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: submodules: true - uses: ./.github/actions/install-rust @@ -52,11 +52,11 @@ jobs: env: CARGO_VET_VERSION: 0.3.0 steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: submodules: true - uses: ./.github/actions/install-rust - - uses: actions/cache@v2 + - uses: actions/cache@v3 with: path: ${{ runner.tool_cache }}/cargo-vet key: cargo-vet-bin-${{ env.CARGO_VET_VERSION }} @@ -68,11 +68,11 @@ jobs: name: Doc build runs-on: ubuntu-latest env: - CARGO_MDBOOK_VERSION: 0.4.8 + CARGO_MDBOOK_VERSION: 0.4.21 RUSTDOCFLAGS: -Dbroken_intra_doc_links --cfg nightlydoc OPENVINO_SKIP_LINKING: 1 steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: submodules: true - uses: ./.github/actions/install-rust @@ -86,7 +86,7 @@ jobs: - run: cd crates/c-api && doxygen doxygen.conf # install mdbook, build the docs, and test the docs - - uses: actions/cache@v2 + - uses: actions/cache@v3 with: path: ${{ runner.tool_cache }}/mdbook key: cargo-mdbook-bin-${{ env.CARGO_MDBOOK_VERSION }} @@ -113,7 +113,7 @@ jobs: mv crates/c-api/html gh-pages/c-api mv target/doc gh-pages/api tar czf gh-pages.tar.gz gh-pages - - uses: actions/upload-artifact@v2 + - uses: actions/upload-artifact@v3 with: name: gh-pages path: gh-pages.tar.gz @@ -137,7 +137,7 @@ jobs: name: Check runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: submodules: true - uses: ./.github/actions/install-rust @@ -190,7 +190,7 @@ jobs: name: Check Windows ARM64 runs-on: windows-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: submodules: true - uses: ./.github/actions/install-rust @@ -201,7 +201,7 @@ jobs: name: Fuzz Targets runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: submodules: true # Note that building with fuzzers requires nightly since it uses unstable @@ -254,7 +254,7 @@ jobs: qemu: qemu-riscv64 -L /usr/riscv64-linux-gnu qemu_target: riscv64-linux-user steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: submodules: true - uses: ./.github/actions/install-rust @@ -271,7 +271,7 @@ jobs: - run: cargo fetch --locked - run: cargo fetch --locked --manifest-path crates/test-programs/wasi-tests/Cargo.toml - - uses: actions/cache@v2 + - uses: actions/cache@v3 with: path: ${{ runner.tool_cache }}/qemu key: qemu-${{ matrix.target }}-${{ env.QEMU_BUILD_VERSION }}-patchmadvise2 @@ -347,7 +347,7 @@ jobs: name: Test wasi-nn module runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: submodules: true - uses: ./.github/actions/install-rust @@ -362,7 +362,7 @@ jobs: name: Test wasi-crypto module runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: submodules: true - run: rustup update stable && rustup default stable @@ -375,7 +375,7 @@ jobs: name: Run benchmarks runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: submodules: true - uses: ./.github/actions/install-rust @@ -387,7 +387,7 @@ jobs: name: Meta deterministic check runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: submodules: true - uses: ./.github/actions/install-rust @@ -425,7 +425,7 @@ jobs: os: ubuntu-latest target: riscv64gc-unknown-linux-gnu steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: submodules: true - uses: ./.github/actions/install-rust @@ -450,7 +450,7 @@ jobs: # Assemble release artifats appropriate for this platform, then upload them # unconditionally to this workflow's files so we have a copy of them. - run: ./ci/build-tarballs.sh "${{ matrix.build }}" "${{ matrix.target }}" - - uses: actions/upload-artifact@v1 + - uses: actions/upload-artifact@v3 with: name: bins-${{ matrix.build }} path: dist @@ -472,7 +472,7 @@ jobs: if: github.repository == 'bytecodealliance/wasmtime' runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: submodules: true - run: rustup update stable && rustup default stable diff --git a/.github/workflows/performance.yml b/.github/workflows/performance.yml index 4a1e419a7a..b108608bb0 100644 --- a/.github/workflows/performance.yml +++ b/.github/workflows/performance.yml @@ -77,11 +77,7 @@ jobs: submodules: true path: wasmtime_commit - - name: Get latest rust toolchain - uses: actions-rs/toolchain@v1 - with: - toolchain: nightly - override: true + - run: rustup update nightly && rustup default nightly - name: Build patch from bytecodealliance/wasmtime (pushed and triggering on this perf repo) working-directory: ./wasmtime_commit @@ -120,7 +116,7 @@ jobs: ./target/release/sightglass-cli summarize --input-format csv --output-format csv -f /tmp/results.csv > /tmp/results_summarized.csv - name: Setup Python - uses: actions/setup-python@v2 + uses: actions/setup-python@v4 with: python-version: '3.9' diff --git a/.github/workflows/publish-to-cratesio.yml b/.github/workflows/publish-to-cratesio.yml index 7fe1991f4e..6d05b66778 100644 --- a/.github/workflows/publish-to-cratesio.yml +++ b/.github/workflows/publish-to-cratesio.yml @@ -14,7 +14,7 @@ jobs: if: github.repository == 'bytecodealliance/wasmtime' runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: submodules: true - run: rustup update stable && rustup default stable diff --git a/.github/workflows/push-tag.yml b/.github/workflows/push-tag.yml index b6adb7e9f0..13208f381b 100644 --- a/.github/workflows/push-tag.yml +++ b/.github/workflows/push-tag.yml @@ -17,7 +17,7 @@ jobs: if: github.repository == 'bytecodealliance/wasmtime' runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: submodules: true fetch-depth: 0 diff --git a/.github/workflows/release-process.yml b/.github/workflows/release-process.yml index 4fe7e5b465..fcbc8382f8 100644 --- a/.github/workflows/release-process.yml +++ b/.github/workflows/release-process.yml @@ -38,7 +38,7 @@ jobs: name: Run the release process runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: submodules: true - name: Setup