T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Narrow allow(dead_code) declarations (#4116)

Browse Source 
* Narrow `allow(dead_code)` declarations

Having module wide `allow(dead_code)` may hide some code that's really
dead. In this commit I just narrowed the declarations to the specific
enum variants that were not used (as it seems reasonable to keep them
and their handling in all the matches, for future use). And the compiler
found more dead code that I think we can remove safely in the short
term.

With this, the only files annotated with a module-wide
`allow(dead_code)` are isle-generated files.

* resurrect some functions as test helpers
This commit is contained in:
Benjamin Bouvier
2022-05-10 12:02:52 +02:00
committed by GitHub
parent 2af8d1e93c
commit 71fc16bbeb
10 changed files with 53 additions and 198 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
cranelift/codegen/src/isa/s390x/inst/emit_tests.rs
View File

@@ -4,6 +4,11 @@ use crate::isa::s390x::settings as s390x_settings;
use crate::settings;
use alloc::vec::Vec;
#[cfg(test)]
fn simm20_zero() -> SImm20 {
SImm20::maybe_from_i64(0).unwrap()
}
#[test]
fn test_s390x_binemit() {
let mut insns = Vec::<(Inst, &str, &str)>::new();
@@ -498,7 +503,7 @@ fn test_s390x_binemit() {
mem: MemArg::BXD20 {
base: gpr(2),
index: zero_reg(),
disp: SImm20::zero(),
disp: simm20_zero(),
flags: MemFlags::trusted(),
},
},
@@ -512,7 +517,7 @@ fn test_s390x_binemit() {
mem: MemArg::BXD20 {
base: gpr(2),
index: zero_reg(),
disp: SImm20::zero(),
disp: simm20_zero(),
flags: MemFlags::trusted(),
},
},
@@ -582,7 +587,7 @@ fn test_s390x_binemit() {
mem: MemArg::BXD20 {
base: gpr(2),
index: zero_reg(),
disp: SImm20::zero(),
disp: simm20_zero(),
flags: MemFlags::trusted(),
},
},
@@ -652,7 +657,7 @@ fn test_s390x_binemit() {
mem: MemArg::BXD20 {
base: gpr(2),
index: zero_reg(),
disp: SImm20::zero(),
disp: simm20_zero(),
flags: MemFlags::trusted(),
},
},
@@ -666,7 +671,7 @@ fn test_s390x_binemit() {
mem: MemArg::BXD20 {
base: gpr(2),
index: zero_reg(),
disp: SImm20::zero(),
disp: simm20_zero(),
flags: MemFlags::trusted(),
},
},
@@ -736,7 +741,7 @@ fn test_s390x_binemit() {
mem: MemArg::BXD20 {
base: gpr(2),
index: zero_reg(),
disp: SImm20::zero(),
disp: simm20_zero(),
flags: MemFlags::trusted(),
},
},
@@ -806,7 +811,7 @@ fn test_s390x_binemit() {
mem: MemArg::BXD20 {
base: gpr(2),
index: zero_reg(),
disp: SImm20::zero(),
disp: simm20_zero(),
flags: MemFlags::trusted(),
},
},
@@ -820,7 +825,7 @@ fn test_s390x_binemit() {
mem: MemArg::BXD20 {
base: gpr(2),
index: zero_reg(),
disp: SImm20::zero(),
disp: simm20_zero(),
flags: MemFlags::trusted(),
},
},
@@ -890,7 +895,7 @@ fn test_s390x_binemit() {
mem: MemArg::BXD20 {
base: gpr(2),
index: zero_reg(),
disp: SImm20::zero(),
disp: simm20_zero(),
flags: MemFlags::trusted(),
},
},
@@ -932,7 +937,7 @@ fn test_s390x_binemit() {
mem: MemArg::BXD20 {
base: gpr(2),
index: zero_reg(),
disp: SImm20::zero(),
disp: simm20_zero(),
flags: MemFlags::trusted(),
},
},
@@ -974,7 +979,7 @@ fn test_s390x_binemit() {
mem: MemArg::BXD20 {
base: gpr(2),
index: zero_reg(),
disp: SImm20::zero(),
disp: simm20_zero(),
flags: MemFlags::trusted(),
},
},
@@ -1573,7 +1578,7 @@ fn test_s390x_binemit() {
mem: MemArg::BXD20 {
base: gpr(2),
index: zero_reg(),
disp: SImm20::zero(),
disp: simm20_zero(),
flags: MemFlags::trusted(),
},
},
@@ -1612,7 +1617,7 @@ fn test_s390x_binemit() {
mem: MemArg::BXD20 {
base: gpr(2),
index: zero_reg(),
disp: SImm20::zero(),
disp: simm20_zero(),
flags: MemFlags::trusted(),
},
},
@@ -1726,7 +1731,7 @@ fn test_s390x_binemit() {
mem: MemArg::BXD20 {
base: gpr(2),
index: zero_reg(),
disp: SImm20::zero(),
disp: simm20_zero(),
flags: MemFlags::trusted(),
},
},