T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

preopt: use replaced arg after having replaced BinaryImm

Browse Source 
when replacing BinaryImm, we use the prior arg, but later use the arg
that was replaced when writing an alias if we can determine the new op
is actually equivalent to a simple copy
This commit is contained in:
iximeow
2019-07-31 19:06:31 -07:00
committed by Benjamin Bouvier
parent 057d4f6e3c
commit 6e57e3f8f3
2 changed files with 17 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
cranelift/codegen/src/simple_preopt.rs
View File

@@ -585,6 +585,7 @@ fn simplify(pos: &mut FuncCursor, inst: Inst) {
InstructionData::BinaryImm { opcode, arg, imm } => {
let ty = pos.func.dfg.ctrl_typevar(inst);
let mut arg = arg;
let mut imm = imm;
match opcode {
Opcode::IaddImm
@@ -613,12 +614,13 @@ fn simplify(pos: &mut FuncCursor, inst: Inst) {
_ => panic!("can't happen"),
};
let new_imm = immediates::Imm64::from(new_imm);
let arg = *prev_arg;
let new_arg = *prev_arg;
pos.func
.dfg
.replace(inst)
.BinaryImm(opcode, ty, new_imm, arg);
.BinaryImm(opcode, ty, new_imm, new_arg);
imm = new_imm;
arg = new_arg;
}
}
}