T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add deprecation notice to cranelift_use_egraphs option. (#5610)

Browse Source 
After #5587, this is on by default. We are retaining the traditional
(no-egraphs) path for now, selected by setting this option to `false`,
but we eventually plan to delete it assuming that we don't find serious
regressions or issues. This PR adds a deprecation notice to the option.
This commit is contained in:
Chris Fallin
2023-01-20 14:52:49 -08:00
committed by GitHub
parent 7e10bd1f58
commit 69cd0a6b1a
2 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
crates/fuzzing/src/generators/config.rs
View File

@@ -141,6 +141,7 @@ impl Config {
} }
/// Converts this to a `wasmtime::Config` object /// Converts this to a `wasmtime::Config` object
#[allow(deprecated)] // Allow use of `cranelift_use_egraphs` below.
pub fn to_wasmtime(&self) -> wasmtime::Config { pub fn to_wasmtime(&self) -> wasmtime::Config {
crate::init_fuzzing(); crate::init_fuzzing();
log::debug!("creating wasmtime config with {:#?}", self.wasmtime); log::debug!("creating wasmtime config with {:#?}", self.wasmtime);

4
crates/wasmtime/src/config.rs
View File

@@ -841,6 +841,10 @@ impl Config {
/// The default value for this is `true`. /// The default value for this is `true`.
#[cfg(compiler)] #[cfg(compiler)]
#[cfg_attr(nightlydoc, doc(cfg(feature = "cranelift")))] // see build.rs #[cfg_attr(nightlydoc, doc(cfg(feature = "cranelift")))] // see build.rs
#[deprecated(
since = "5.0.0",
note = "egraphs will be the default and this method will be removed in a future version."
)]
pub fn cranelift_use_egraphs(&mut self, enable: bool) -> &mut Self { pub fn cranelift_use_egraphs(&mut self, enable: bool) -> &mut Self {
let val = if enable { "true" } else { "false" }; let val = if enable { "true" } else { "false" };
self.compiler_config self.compiler_config