T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add __dso_handle to exception list of deprecated export symbols

Browse Source 
When compiling C to WASM with clang-8, __dso_handle is a global
that maybe exported but that currently is not whitelisted along
with __heap_base and _data_end to be handled as allowable depricated
exports. This PR adds the case for __dso_handle.
This commit is contained in:
Johnnie Birch
2020-07-02 13:13:49 -07:00
parent b700646c93
commit 60681d7019
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
crates/wasmtime/src/linker.rs
View File

@@ -445,6 +445,11 @@ impl Linker {
// which use --export-dynamic, which unfortunately doesn't work the way // which use --export-dynamic, which unfortunately doesn't work the way
// we want it to. // we want it to.
warn!("command module exporting '__heap_base' is deprecated"); warn!("command module exporting '__heap_base' is deprecated");
} else if export.name() == "__dso_handle" && export.ty().global().is_some() {
// Allow an exported "__dso_handle" memory for compatibility with toolchains
// which use --export-dynamic, which unfortunately doesn't work the way
// we want it to.
warn!("command module exporting '__dso_handle' is deprecated")
} else if export.name() == "__rtti_base" && export.ty().global().is_some() { } else if export.name() == "__rtti_base" && export.ty().global().is_some() {
// Allow an exported "__rtti_base" memory for compatibility with // Allow an exported "__rtti_base" memory for compatibility with
// AssemblyScript. // AssemblyScript.