code review: remove unsafe on borrow checker constructor

This commit is contained in:
Pat Hickey
2020-06-30 10:10:10 -07:00
parent 05201b514d
commit 5f5d7cb0f7
4 changed files with 4 additions and 4 deletions

View File

@@ -12,7 +12,7 @@ impl BorrowChecker {
/// `GuestSlice` and `GuestStr` structs, which implement `std::ops::Deref` and /// `GuestSlice` and `GuestStr` structs, which implement `std::ops::Deref` and
/// `std::ops::DerefMut`. It also enforces that `GuestPtr::read` and `GuestPtr::write` do not /// `std::ops::DerefMut`. It also enforces that `GuestPtr::read` and `GuestPtr::write` do not
/// access memory with an outstanding borrow. /// access memory with an outstanding borrow.
pub unsafe fn new() -> Self { pub fn new() -> Self {
BorrowChecker { BorrowChecker {
bc: RefCell::new(InnerBorrowChecker::new()), bc: RefCell::new(InnerBorrowChecker::new()),
} }

View File

@@ -60,7 +60,7 @@ impl HostMemory {
buffer: HostBuffer { buffer: HostBuffer {
cell: UnsafeCell::new([0; 4096]), cell: UnsafeCell::new([0; 4096]),
}, },
bc: unsafe { BorrowChecker::new() }, bc: BorrowChecker::new(),
} }
} }

View File

@@ -12,7 +12,7 @@ impl BorrowChecker {
/// `GuestSlice` and `GuestStr` structs, which implement `std::ops::Deref` and /// `GuestSlice` and `GuestStr` structs, which implement `std::ops::Deref` and
/// `std::ops::DerefMut`. It also enforces that `GuestPtr::read` and `GuestPtr::write` do not /// `std::ops::DerefMut`. It also enforces that `GuestPtr::read` and `GuestPtr::write` do not
/// access memory with an outstanding borrow. /// access memory with an outstanding borrow.
pub unsafe fn new() -> Self { pub fn new() -> Self {
BorrowChecker { BorrowChecker {
bc: RefCell::new(InnerBorrowChecker::new()), bc: RefCell::new(InnerBorrowChecker::new()),
} }

View File

@@ -25,7 +25,7 @@ impl WasmtimeGuestMemory {
// This BorrowChecker construction is a holdover until it is // This BorrowChecker construction is a holdover until it is
// integrated fully with wasmtime: // integrated fully with wasmtime:
// https://github.com/bytecodealliance/wasmtime/issues/1917 // https://github.com/bytecodealliance/wasmtime/issues/1917
bc: unsafe { BorrowChecker::new() }, bc: BorrowChecker::new(),
} }
} }
} }