T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make get_libcall_funcref pub(crate) (#1291)

Browse Source 
* Make `get_libcall_funcref` `pub(crate)`

Closes https://github.com/bytecodealliance/cranelift/issues/1273.

Since get_libcall_funcref is only used internally by the verifier,
it doesn't make sense to have it be public. This will encourage users to
look elsewhere for `memcpy` (they should be looking at
https://docs.rs/cranelift-frontend/0.51.0/cranelift_frontend/struct.FunctionBuilder.html#method.emit_small_memcpy)
This commit is contained in:
Joshua Nelson
2020-01-24 10:43:44 -05:00
committed by Benjamin Bouvier
parent c360007b19
commit 5edf015ada
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cranelift/codegen/src/ir/libcall.rs
View File

@@ -106,7 +106,7 @@ impl LibCall {
/// for `inst`. /// for `inst`.
/// ///
/// If there is an existing reference, use it, otherwise make a new one. /// If there is an existing reference, use it, otherwise make a new one.
pub fn get_libcall_funcref( pub(crate) fn get_libcall_funcref(
libcall: LibCall, libcall: LibCall,
call_conv: CallConv, call_conv: CallConv,
func: &mut Function, func: &mut Function,

4
cranelift/codegen/src/ir/mod.rs
View File

@@ -14,7 +14,7 @@ pub mod immediates;
pub mod instructions; pub mod instructions;
pub mod jumptable; pub mod jumptable;
pub mod layout; pub mod layout;
mod libcall; pub(crate) mod libcall;
mod memflags; mod memflags;
mod progpoint; mod progpoint;
mod sourceloc; mod sourceloc;
@@ -49,7 +49,7 @@ pub use crate::ir::instructions::{
}; };
pub use crate::ir::jumptable::JumpTableData; pub use crate::ir::jumptable::JumpTableData;
pub use crate::ir::layout::Layout; pub use crate::ir::layout::Layout;
pub use crate::ir::libcall::{get_libcall_funcref, get_probestack_funcref, LibCall}; pub use crate::ir::libcall::{get_probestack_funcref, LibCall};
pub use crate::ir::memflags::MemFlags; pub use crate::ir::memflags::MemFlags;
pub use crate::ir::progpoint::{ExpandedProgramPoint, ProgramOrder, ProgramPoint}; pub use crate::ir::progpoint::{ExpandedProgramPoint, ProgramOrder, ProgramPoint};
pub use crate::ir::sourceloc::SourceLoc; pub use crate::ir::sourceloc::SourceLoc;

2
cranelift/codegen/src/legalizer/libcall.rs
View File

@@ -1,7 +1,7 @@
//! Expanding instructions as runtime library calls. //! Expanding instructions as runtime library calls.
use crate::ir; use crate::ir;
use crate::ir::{get_libcall_funcref, InstBuilder}; use crate::ir::{libcall::get_libcall_funcref, InstBuilder};
use crate::isa::{CallConv, TargetIsa}; use crate::isa::{CallConv, TargetIsa};
use crate::legalizer::boundary::legalize_libcall_signature; use crate::legalizer::boundary::legalize_libcall_signature;
use alloc::vec::Vec; use alloc::vec::Vec;