cranelift: Add missing control plane parameter to compile_with_cache (#6289)
It seems that this fell through given that the incremental cache is behind a cargo feature. I noticed this while building `cranelift-codegen` via `cargo build --all-features`. I decided to add a check in CI to hopefully prevent this in the future, but I'm happy to remove it / update it if there's a better way or another way.
This commit is contained in:
1
.github/workflows/main.yml
vendored
1
.github/workflows/main.yml
vendored
@@ -263,6 +263,7 @@ jobs:
|
||||
- run: cargo check -p wasmtime --no-default-features --features cranelift,wat,async,cache
|
||||
- run: cargo check -p wasmtime --no-default-features --features winch
|
||||
- run: cargo check --features component-model
|
||||
- run: cargo check -p wasmtime --features incremental-cache
|
||||
|
||||
# Check that benchmarks of the cranelift project build
|
||||
- run: cargo check --benches -p cranelift-codegen
|
||||
|
||||
@@ -581,7 +581,7 @@ mod incremental_cache {
|
||||
|
||||
let mut cache_store = CraneliftCacheStore(cache_ctx.cache_store.clone());
|
||||
let (compiled_code, from_cache) = context
|
||||
.compile_with_cache(isa, &mut cache_store)
|
||||
.compile_with_cache(isa, &mut cache_store, &mut Default::default())
|
||||
.map_err(|error| CompileError::Codegen(pretty_error(&error.func, error.inner)))?;
|
||||
|
||||
if from_cache {
|
||||
|
||||
Reference in New Issue
Block a user