T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cranelift: Add missing control plane parameter to compile_with_cache (#6289)

Browse Source 
It seems that this fell through given that the incremental cache is
behind a cargo feature. I noticed this while building
`cranelift-codegen` via `cargo build --all-features`.

I decided to add a check in CI to hopefully prevent this in the future,
but I'm happy to remove it / update it if there's a better way or another way.
This commit is contained in:
Saúl Cabrera
2023-04-26 17:37:35 +02:00
committed by GitHub
parent ec6755512f
commit 5d833a766e
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
.github/workflows/main.yml vendored
View File

@@ -263,6 +263,7 @@ jobs:
- run: cargo check -p wasmtime --no-default-features --features cranelift,wat,async,cache - run: cargo check -p wasmtime --no-default-features --features cranelift,wat,async,cache
- run: cargo check -p wasmtime --no-default-features --features winch - run: cargo check -p wasmtime --no-default-features --features winch
- run: cargo check --features component-model - run: cargo check --features component-model
- run: cargo check -p wasmtime --features incremental-cache
# Check that benchmarks of the cranelift project build # Check that benchmarks of the cranelift project build
- run: cargo check --benches -p cranelift-codegen - run: cargo check --benches -p cranelift-codegen

2
crates/cranelift/src/compiler.rs
View File

@@ -581,7 +581,7 @@ mod incremental_cache {
let mut cache_store = CraneliftCacheStore(cache_ctx.cache_store.clone()); let mut cache_store = CraneliftCacheStore(cache_ctx.cache_store.clone());
let (compiled_code, from_cache) = context let (compiled_code, from_cache) = context
.compile_with_cache(isa, &mut cache_store) .compile_with_cache(isa, &mut cache_store, &mut Default::default())
.map_err(|error| CompileError::Codegen(pretty_error(&error.func, error.inner)))?; .map_err(|error| CompileError::Codegen(pretty_error(&error.func, error.inner)))?;
if from_cache { if from_cache {