T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make InstructionData comparable and hashable (#388)

Browse Source 
* Don't implement Eq and Hash for EntityList

* Generate eq and hash methods for InstructionData

* Use the eq() and hash() methods of InstructionData in simple_gvn
This commit is contained in:
Amanieu d'Antras
2018-07-06 20:09:20 +01:00
committed by Dan Gohman
parent 4f352fa6f1
commit 5c7aeb46dd
3 changed files with 158 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
lib/entity/src/list.rs
View File

@@ -1,5 +1,4 @@
//! Small lists of entity references.
use std::hash::{Hash, Hasher};
use std::marker::PhantomData;
use std::mem;
use std::vec::Vec;
@@ -34,9 +33,8 @@ use EntityRef;
/// function they belong to. *Cloning an entity list does not allocate new memory for the clone*.
/// It creates an alias of the same memory.
///
/// Entity lists can also be hashed and compared for equality, but those operations just panic if
/// they're ever actually called, because it's not possible to compare the contents of the list
/// without the pool reference.
/// Entity lists cannot be hashed and compared for equality because it's not possible to compare the
/// contents of the list without the pool reference.
///
/// # Implementation
///
@@ -76,19 +74,6 @@ impl<T: EntityRef> Default for EntityList<T> {
}
}
impl<T: EntityRef> Hash for EntityList<T> {
fn hash<H: Hasher>(&self, _: &mut H) {
panic!("hash called on EntityList");
}
}
impl<T: EntityRef> PartialEq for EntityList<T> {
fn eq(&self, _: &Self) -> bool {
panic!("eq called on EntityList");
}
}
impl<T: EntityRef> Eq for EntityList<T> {}
/// A memory pool for storing lists of `T`.
#[derive(Clone, Debug)]
pub struct ListPool<T: EntityRef> {