x64: Migrate {s,u}{div,rem} to ISLE (#6008)
* x64: Add precise-output tests for div traps
This adds a suite of `*.clif` files which are intended to test the
`avoid_div_traps=true` compilation of the `{s,u}{div,rem}` instructions.
* x64: Remove conditional regalloc in `Div` instruction
Move the 8-bit `Div` logic into a dedicated `Div8` instruction to avoid
having conditionally-used registers with respect to regalloc.
* x64: Migrate non-trapping, `udiv`/`urem` to ISLE
* x64: Port checked `udiv` to ISLE
* x64: Migrate urem entirely to ISLE
* x64: Use `test` instead of `cmp` to compare-to-zero
* x64: Port `sdiv` lowering to ISLE
* x64: Port `srem` lowering to ISLE
* Tidy up regalloc behavior and fix tests
* Update docs and winch
* Review comments
* Reword again
* More refactoring test fixes
* More test fixes
This commit is contained in:
@@ -530,8 +530,8 @@
|
||||
|
||||
;;;; Helpers for accessing compilation flags ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
|
||||
|
||||
(decl avoid_div_traps () Type)
|
||||
(extern extractor avoid_div_traps avoid_div_traps)
|
||||
(decl pure avoid_div_traps () bool)
|
||||
(extern constructor avoid_div_traps avoid_div_traps)
|
||||
|
||||
;; This definition should be kept up to date with the values defined in
|
||||
;; cranelift/codegen/meta/src/shared/settings.rs
|
||||
@@ -722,6 +722,10 @@
|
||||
(decl gen_return (ValueSlice) Unit)
|
||||
(extern constructor gen_return gen_return)
|
||||
|
||||
;; Helper for extracting an immediate that's not 0 and not -1 from an imm64.
|
||||
(decl pure partial safe_divisor_from_imm64 (Type Imm64) u64)
|
||||
(extern constructor safe_divisor_from_imm64 safe_divisor_from_imm64)
|
||||
|
||||
;;;; Automatic conversions ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
|
||||
|
||||
(convert Inst Value def_inst)
|
||||
|
||||
Reference in New Issue
Block a user