From 574031e4d2779fc2804d92f85715205545434c17 Mon Sep 17 00:00:00 2001 From: Dan Gohman Date: Thu, 31 Aug 2017 11:49:33 -0700 Subject: [PATCH] Avoid unneeded passing by value. https://github.com/rust-lang-nursery/rust-clippy/wiki#needless_pass_by_value --- lib/wasm/src/code_translator.rs | 2 +- lib/wasm/src/module_translator.rs | 4 ++-- lib/wasm/src/translation_utils.rs | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/wasm/src/code_translator.rs b/lib/wasm/src/code_translator.rs index f4547f5003..a4ad9f7445 100644 --- a/lib/wasm/src/code_translator.rs +++ b/lib/wasm/src/code_translator.rs @@ -156,7 +156,7 @@ impl FunctionImports { pub fn translate_function_body( parser: &mut Parser, function_index: FunctionIndex, - sig: Signature, + sig: &Signature, locals: &[(usize, Type)], exports: &Option>, signatures: &[Signature], diff --git a/lib/wasm/src/module_translator.rs b/lib/wasm/src/module_translator.rs index eeaf5f67e5..ba99b5593b 100644 --- a/lib/wasm/src/module_translator.rs +++ b/lib/wasm/src/module_translator.rs @@ -260,7 +260,7 @@ pub fn translate_module( match translate_function_body( &mut parser, function_index, - signature, + &signature, &locals, &exports, &signatures, @@ -271,7 +271,7 @@ pub fn translate_module( Ok((il_func, imports)) => { il_functions.push(FunctionTranslation::Code { il: il_func, - imports: invert_hashmaps(imports), + imports: invert_hashmaps(&imports), }) } Err(s) => return Err(s), diff --git a/lib/wasm/src/translation_utils.rs b/lib/wasm/src/translation_utils.rs index 645b236f5d..15099f475b 100644 --- a/lib/wasm/src/translation_utils.rs +++ b/lib/wasm/src/translation_utils.rs @@ -140,7 +140,7 @@ pub fn translate_type(ty: wasmparser::Type) -> Result, ( /// feeding the function indexes in the module but are used by the runtime with the `FuncRef` as /// keys. pub fn invert_hashmaps( - imports: code_translator::FunctionImports, + imports: &code_translator::FunctionImports, ) -> module_translator::ImportMappings { let mut new_imports = module_translator::ImportMappings::new(); for (func_index, func_ref) in &imports.functions {