Migrate from failure to thiserror and anyhow (#436)

* Migrate from failure to thiserror and anyhow

The failure crate invents its own traits that don't use
std::error::Error (because failure predates certain features added to
Error); this prevents using ? on an error from failure in a function
using Error. The thiserror and anyhow crates integrate with the standard
Error trait instead.

This change does not attempt to semantically change or refactor the
approach to error-handling in any portion of the code, to ensure that
the change remains straightforward to review. Modules using specific
differentiated error types move from failure_derive and derive(Fail) to
thiserror and derive(Error). Modules boxing all errors opaquely move
from failure::Error to anyhow. Modules using String as an error type
continue to do so. Code using unwrap or expect continues to do so.

Drop Display implementations when thiserror can easily derive an
identical instance.

Drop manual traversal of iter_causes; anyhow's Debug instance prints the
chain of causes by default.

Use anyhow's type alias anyhow::Result<T> in place of
std::result::Result<T, anyhow::Error> whenever possible.

* wasm2obj: Simplify error handling using existing messages

handle_module in wasm2obj manually maps
cranelift_codegen::isa::LookupError values to strings, but LookupError
values already have strings that say almost exactly the same thing.
Rely on the strings from cranelift.

* wasmtime: Rely on question-mark-in-main

The main() wrapper around rmain() completely matches the behavior of
question-mark-in-main (print error to stderr and return 1), so switch to
question-mark-in-main.

* Update to walrus 0.13 and wasm-webidl-bindings 0.6

Both crates switched from failure to anyhow; updating lets us avoid a
translation from failure to anyhow within wasmtime-interface-types.

wasmtime-environ/src/compilation.rs

@@ -10,6 +10,7 @@ use cranelift_entity::PrimaryMap;
 use cranelift_wasm::{DefinedFuncIndex, FuncIndex, ModuleTranslationState, WasmError};
 use serde::{Deserialize, Serialize};
 use std::ops::Range;
+use thiserror::Error;
 
 /// Compiled machine code: body and jump table offsets.
 #[derive(Serialize, Deserialize, Debug, Clone, PartialEq, Eq)]
@@ -144,18 +145,18 @@ pub struct TrapInformation {
 pub type Traps = PrimaryMap<DefinedFuncIndex, Vec<TrapInformation>>;
 
 /// An error while compiling WebAssembly to machine code.
-#[derive(Fail, Debug)]
+#[derive(Error, Debug)]
 pub enum CompileError {
     /// A wasm translation error occured.
-    #[fail(display = "WebAssembly translation error: {}", _0)]
-    Wasm(WasmError),
+    #[error("WebAssembly translation error: {0}")]
+    Wasm(#[from] WasmError),
 
     /// A compilation error occured.
-    #[fail(display = "Compilation error: {}", _0)]
-    Codegen(CodegenError),
+    #[error("Compilation error: {0}")]
+    Codegen(#[from] CodegenError),
 
     /// A compilation error occured.
-    #[fail(display = "Debug info is not supported with this configuration")]
+    #[error("Debug info is not supported with this configuration")]
     DebugInfoNotSupported,
 }
 

wasmtime-environ/src/cranelift.rs

@@ -226,29 +226,25 @@ impl crate::compilation::Compiler for Cranelift {
                                 context.func.collect_debug_info();
                             }
 
-                            func_translator
-                                .translate(
-                                    module_translation,
-                                    input.data,
-                                    input.module_offset,
-                                    &mut context.func,
-                                    &mut FuncEnvironment::new(isa.frontend_config(), module),
-                                )
-                                .map_err(CompileError::Wasm)?;
+                            func_translator.translate(
+                                module_translation,
+                                input.data,
+                                input.module_offset,
+                                &mut context.func,
+                                &mut FuncEnvironment::new(isa.frontend_config(), module),
+                            )?;
 
                             let mut code_buf: Vec<u8> = Vec::new();
                             let mut reloc_sink = RelocSink::new(func_index);
                             let mut trap_sink = TrapSink::new();
                             let mut stackmap_sink = binemit::NullStackmapSink {};
-                            context
-                                .compile_and_emit(
-                                    isa,
-                                    &mut code_buf,
-                                    &mut reloc_sink,
-                                    &mut trap_sink,
-                                    &mut stackmap_sink,
-                                )
-                                .map_err(CompileError::Codegen)?;
+                            context.compile_and_emit(
+                                isa,
+                                &mut code_buf,
+                                &mut reloc_sink,
+                                &mut trap_sink,
+                                &mut stackmap_sink,
+                            )?;
 
                             let jt_offsets = context.func.jt_offsets.clone();
 
@@ -260,11 +256,7 @@ impl crate::compilation::Compiler for Cranelift {
                             };
 
                             let ranges = if generate_debug_info {
-                                Some(
-                                    context
-                                        .build_value_labels_ranges(isa)
-                                        .map_err(CompileError::Codegen)?,
-                                )
+                                Some(context.build_value_labels_ranges(isa)?)
                             } else {
                                 None
                             };

wasmtime-environ/src/lib.rs

@@ -27,9 +27,6 @@
 
 extern crate alloc;
 
-#[macro_use]
-extern crate failure_derive;
-
 mod address_map;
 mod compilation;
 mod func_environ;