diff --git a/cranelift/codegen/meta/src/shared/instructions.rs b/cranelift/codegen/meta/src/shared/instructions.rs index 2bb8d9a637..955782039d 100644 --- a/cranelift/codegen/meta/src/shared/instructions.rs +++ b/cranelift/codegen/meta/src/shared/instructions.rs @@ -2454,8 +2454,7 @@ pub(crate) fn define( Unsigned integer multiplication, producing the high half of a double-length result. - Polymorphic over all scalar integer types, but does not support vector - types. + Polymorphic over all integer types (vector and scalar). "#, &formats.binary, ) diff --git a/cranelift/filetests/filetests/runtests/simd-umulhi-aarch64.clif b/cranelift/filetests/filetests/runtests/simd-umulhi-aarch64.clif deleted file mode 100644 index db94f2f648..0000000000 --- a/cranelift/filetests/filetests/runtests/simd-umulhi-aarch64.clif +++ /dev/null @@ -1,40 +0,0 @@ -test interpret -test run -target aarch64 -; x86_64 only supports `i16`, `i32`, and `i64` - -function %umulhi_i8(i8, i8) -> i8 { -block0(v0: i8, v1: i8): - v2 = umulhi v0, v1 - return v2 -} -; run: %umulhi_i8(2, 4) == 0 -; run: %umulhi_i8(255, 255) == 254 - -function %umulhi_i8x16(i8x16, i8x16) -> i8x16 { -block0(v0: i8x16, v1: i8x16): - v2 = umulhi v0, v1 - return v2 -} -; run: %umulhi_i8x16([1 2 3 4 5 6 7 8 255 255 255 255 255 255 255 255], [9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 255]) == [0 0 0 0 0 0 0 0 16 17 18 19 20 21 22 254] - -function %umulhi_i16x8(i16x8, i16x8) -> i16x8 { -block0(v0: i16x8, v1: i16x8): - v2 = umulhi v0, v1 - return v2 -} -; run: %umulhi_i16x8([1 2 255 255 255 255 65535 65535], [3 4 5 6 7 8 9 65535]) == [0 0 0 0 0 0 8 65534] - -function %umulhi_i32x4(i32x4, i32x4) -> i32x4 { -block0(v0: i32x4, v1: i32x4): - v2 = umulhi v0, v1 - return v2 -} -; run: %umulhi_i32x4([1 255 65535 4294967295], [2 65535 4294967295 4294967295]) == [0 0 65534 4294967294] - -function %umulhi_i64x2(i64x2, i64x2) -> i64x2 { -block0(v0: i64x2, v1: i64x2): - v2 = umulhi v0, v1 - return v2 -} -; run: %umulhi_i64x2([1 18446744073709551615], [2 18446744073709551615]) == [0 18446744073709551614] \ No newline at end of file diff --git a/cranelift/filetests/filetests/runtests/simd-umulhi.clif b/cranelift/filetests/filetests/runtests/simd-umulhi.clif index fd643151ab..b383bf5082 100644 --- a/cranelift/filetests/filetests/runtests/simd-umulhi.clif +++ b/cranelift/filetests/filetests/runtests/simd-umulhi.clif @@ -1,29 +1,38 @@ test interpret -test run -target aarch64 -set enable_simd -target x86_64 +; x86_64 only supports `i16`, `i32`, and `i64` -function %umulhi_i16(i16, i16) -> i16 { -block0(v0: i16, v1: i16): +function %umulhi_i8(i8, i8) -> i8 { +block0(v0: i8, v1: i8): v2 = umulhi v0, v1 return v2 } -; run: %umulhi_i16(2, 4) == 0 -; run: %umulhi_i16(65535, 65535) == 65534 +; run: %umulhi_i8(2, 4) == 0 +; run: %umulhi_i8(255, 255) == 254 -function %umulhi_i32(i32, i32) -> i32 { -block0(v0: i32, v1: i32): +function %umulhi_i8x16(i8x16, i8x16) -> i8x16 { +block0(v0: i8x16, v1: i8x16): v2 = umulhi v0, v1 return v2 } -; run: %umulhi_i32(500, 700) == 0 -; run: %umulhi_i32(4294967295, 4294967295) == 4294967294 +; run: %umulhi_i8x16([1 2 3 4 5 6 7 8 255 255 255 255 255 255 255 255], [9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 255]) == [0 0 0 0 0 0 0 0 16 17 18 19 20 21 22 254] -function %umulhi_i64(i64, i64) -> i64 { -block0(v0: i64, v1: i64): +function %umulhi_i16x8(i16x8, i16x8) -> i16x8 { +block0(v0: i16x8, v1: i16x8): v2 = umulhi v0, v1 return v2 } -; run: %umulhi_i64(4294967295, 4294967295) == 0 -; run: %umulhi_i64(18446744073709551615, 18446744073709551615) == 18446744073709551614 +; run: %umulhi_i16x8([1 2 255 255 255 255 65535 65535], [3 4 5 6 7 8 9 65535]) == [0 0 0 0 0 0 8 65534] + +function %umulhi_i32x4(i32x4, i32x4) -> i32x4 { +block0(v0: i32x4, v1: i32x4): + v2 = umulhi v0, v1 + return v2 +} +; run: %umulhi_i32x4([1 255 65535 4294967295], [2 65535 4294967295 4294967295]) == [0 0 65534 4294967294] + +function %umulhi_i64x2(i64x2, i64x2) -> i64x2 { +block0(v0: i64x2, v1: i64x2): + v2 = umulhi v0, v1 + return v2 +} +; run: %umulhi_i64x2([1 18446744073709551615], [2 18446744073709551615]) == [0 18446744073709551614] \ No newline at end of file diff --git a/cranelift/filetests/filetests/runtests/umulhi.clif b/cranelift/filetests/filetests/runtests/umulhi.clif new file mode 100644 index 0000000000..bb6b06bedd --- /dev/null +++ b/cranelift/filetests/filetests/runtests/umulhi.clif @@ -0,0 +1,29 @@ +test interpret +test run +target aarch64 +set enable_simd +target x86_64 machinst + +function %umulhi_i16(i16, i16) -> i16 { +block0(v0: i16, v1: i16): + v2 = umulhi v0, v1 + return v2 +} +; run: %umulhi_i16(2, 4) == 0 +; run: %umulhi_i16(65535, 65535) == 65534 + +function %umulhi_i32(i32, i32) -> i32 { +block0(v0: i32, v1: i32): + v2 = umulhi v0, v1 + return v2 +} +; run: %umulhi_i32(500, 700) == 0 +; run: %umulhi_i32(4294967295, 4294967295) == 4294967294 + +function %umulhi_i64(i64, i64) -> i64 { +block0(v0: i64, v1: i64): + v2 = umulhi v0, v1 + return v2 +} +; run: %umulhi_i64(4294967295, 4294967295) == 0 +; run: %umulhi_i64(18446744073709551615, 18446744073709551615) == 18446744073709551614