riscv64: Fix masking on iabs (#5505)

* cranelift: Add `iabs.i128` runtest

* riscv64: Fix incorrect extension in iabs

When lowering iabs, we were accidentally comparing the unextended value
this caused the instruction to misbehave with certain top bits.

This commit also adds a zbb lowering that does not use jumps.
This commit is contained in:
Afonso Bordado
2023-01-04 01:37:25 +00:00
committed by GitHub
parent 276bc6ad2e
commit 52ba72f341
8 changed files with 172 additions and 15 deletions

View File

@@ -0,0 +1,50 @@
test compile precise-output
target riscv64 has_zbb=true
function %iabs_i8(i8) -> i8 {
block0(v0: i8):
v1 = iabs v0
return v1
}
; block0:
; sext.b t2,a0
; sub a1,zero,t2
; max a0,t2,a1
; ret
function %iabs_i16(i16) -> i16 {
block0(v0: i16):
v1 = iabs v0
return v1
}
; block0:
; sext.h t2,a0
; sub a1,zero,t2
; max a0,t2,a1
; ret
function %iabs_i32(i32) -> i32 {
block0(v0: i32):
v1 = iabs v0
return v1
}
; block0:
; sext.w t2,a0
; sub a1,zero,t2
; max a0,t2,a1
; ret
function %iabs_i64(i64) -> i64 {
block0(v0: i64):
v1 = iabs v0
return v1
}
; block0:
; sub t2,zero,a0
; max a0,a0,t2
; ret

View File

@@ -0,0 +1,50 @@
test compile precise-output
target riscv64 has_zbb=false
function %iabs_i8(i8) -> i8 {
block0(v0: i8):
v1 = iabs v0
return v1
}
; block0:
; sext.b t2,a0
; sub a1,zero,t2
; select_reg a0,t2,a1##condition=(t2 sgt a1)
; ret
function %iabs_i16(i16) -> i16 {
block0(v0: i16):
v1 = iabs v0
return v1
}
; block0:
; sext.h t2,a0
; sub a1,zero,t2
; select_reg a0,t2,a1##condition=(t2 sgt a1)
; ret
function %iabs_i32(i32) -> i32 {
block0(v0: i32):
v1 = iabs v0
return v1
}
; block0:
; sext.w t2,a0
; sub a1,zero,t2
; select_reg a0,t2,a1##condition=(t2 sgt a1)
; ret
function %iabs_i64(i64) -> i64 {
block0(v0: i64):
v1 = iabs v0
return v1
}
; block0:
; sub t2,zero,a0
; select_reg a0,a0,t2##condition=(a0 sgt t2)
; ret