diff --git a/crates/test-programs/TEST_FAILURES b/crates/test-programs/TEST_FAILURES index f7b0fcd60d..2ae868ad65 100644 --- a/crates/test-programs/TEST_FAILURES +++ b/crates/test-programs/TEST_FAILURES @@ -21,16 +21,14 @@ * nofollow_errors - I loosened up some errno acceptance but windows requires rmdir to delete a symlink to a directory, rather than unlink_file - - dan is doing the upstream fix rn + - fix merged in next cap-std release * symlink_create - narrowed down the symlink delete issue that only shows up on linux - dan is doing the upstream fix rn * path_rename - permission denied on windows to rename a dir to an existing empty dir - - we're not going to try to emulate this functionality. - - the test should be modified accept this operation failing completely on windows. * path_link - - fails on the first dangling symlink + - passes everything except dangling symlinks * fd_flags_set - same metadata panic as fd_readdir * path_filestat @@ -49,3 +47,11 @@ - different errno in one case * unlink_file_trailing_slashes - different errnos in three spots + + +# Test Divergences + +* fd_allocate supported or not +* dangling symlinks supported or not +* errno: windows or linux mode? + diff --git a/crates/test-programs/wasi-tests/src/bin/path_link.rs b/crates/test-programs/wasi-tests/src/bin/path_link.rs index f7f576f3ed..16d827e8dd 100644 --- a/crates/test-programs/wasi-tests/src/bin/path_link.rs +++ b/crates/test-programs/wasi-tests/src/bin/path_link.rs @@ -155,6 +155,7 @@ unsafe fn test_path_link(dir_fd: wasi::Fd) { "errno should be ERRNO_NOENT" ); + // XXX windows doesnt support dangling symlinks - rest of file // Create a link to a dangling symlink wasi::path_symlink("target", dir_fd, "symlink").expect("creating a dangling symlink"); diff --git a/crates/test-programs/wasi-tests/src/bin/path_rename.rs b/crates/test-programs/wasi-tests/src/bin/path_rename.rs index 1acd276f08..37a9bf8169 100644 --- a/crates/test-programs/wasi-tests/src/bin/path_rename.rs +++ b/crates/test-programs/wasi-tests/src/bin/path_rename.rs @@ -134,6 +134,7 @@ unsafe fn test_path_rename(dir_fd: wasi::Fd) { wasi::fd_close(fd).expect("closing a file"); wasi::path_unlink_file(dir_fd, "target").expect("removing a file"); + // XXX windows does not support this operation // Try renaming to an (empty) directory instead create_file(dir_fd, "source"); wasi::path_create_directory(dir_fd, "target").expect("creating a directory");