T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Cranelift: Remove duplicate IR signature legalizations (#5093)

Browse Source 
The `SigData::from_func_sig` constructor will already ensure that the struct
return pointer is returned, so this is a purely unnecessary call.

Note that this is not a performance speed up, since
`ensure_struct_return_ptr_is_returned` doesn't do any significant work if the
signature is already legalized.
This commit is contained in:
Nick Fitzgerald
2022-10-21 13:08:44 -07:00
committed by GitHub
parent 9dadba60a0
commit 4a66c3b855
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
cranelift/codegen/src/machinst/abi.rs
View File

@@ -773,8 +773,7 @@ impl SigSet {
// `ir::Signature`. // `ir::Signature`.
debug_assert!(!self.have_abi_sig_for_signature(&signature)); debug_assert!(!self.have_abi_sig_for_signature(&signature));
let legalized_signature = crate::machinst::ensure_struct_return_ptr_is_returned(&signature); let sig_data = SigData::from_func_sig::<M>(&signature, flags)?;
let sig_data = SigData::from_func_sig::<M>(&legalized_signature, flags)?;
let sig = self.sigs.push(sig_data); let sig = self.sigs.push(sig_data);
self.ir_signature_to_abi_sig.insert(signature, sig); self.ir_signature_to_abi_sig.insert(signature, sig);
Ok(sig) Ok(sig)
@@ -793,8 +792,7 @@ impl SigSet {
return Ok(sig); return Ok(sig);
} }
let signature = &dfg.signatures[sig_ref]; let signature = &dfg.signatures[sig_ref];
let legalized_signature = crate::machinst::ensure_struct_return_ptr_is_returned(&signature); let sig_data = SigData::from_func_sig::<M>(signature, flags)?;
let sig_data = SigData::from_func_sig::<M>(&legalized_signature, flags)?;
let sig = self.sigs.push(sig_data); let sig = self.sigs.push(sig_data);
self.ir_sig_ref_to_abi_sig[sig_ref] = Some(sig); self.ir_sig_ref_to_abi_sig[sig_ref] = Some(sig);
Ok(sig) Ok(sig)