From 46ac24d172b5829088772bda4a82f503a4b2ee2d Mon Sep 17 00:00:00 2001 From: Dan Gohman Date: Fri, 17 Nov 2017 11:13:14 -0800 Subject: [PATCH] Add a comment about call_indirect bounds/signature checking. --- lib/runtime/src/lib.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/runtime/src/lib.rs b/lib/runtime/src/lib.rs index 9a5f074fd9..8c91be56f2 100644 --- a/lib/runtime/src/lib.rs +++ b/lib/runtime/src/lib.rs @@ -287,6 +287,8 @@ impl<'module_environment> cton_wasm::FuncEnvironment for FuncEnvironment<'module callee: ir::Value, call_args: &[ir::Value], ) -> ir::Inst { + // TODO: Cretonne's call_indirect doesn't implement bounds checking + // or signature checking, so we need to implement it ourselves. debug_assert_eq!(table_index, 0, "non-default tables not supported yet"); let real_call_args = FuncEnvironment::get_real_call_args(pos.func, call_args); pos.ins().call_indirect(sig_ref, callee, &real_call_args)