Code review feedback.

* Expand doc comment on `Engine::precompile_module`.
* Add FIXME comment regarding a future ISA flag compatibility check before
  doing a JIT from `Module::from_binary`.
* Remove no-longer-needed CLI groups from the `compile` command.
This commit is contained in:
Peter Huene
2021-04-01 11:48:33 -07:00
parent 9e7d2fed98
commit 3da03bcfcf
3 changed files with 14 additions and 8 deletions

View File

@@ -4,10 +4,7 @@ use crate::CommonOptions;
use anyhow::{bail, Context, Result};
use std::fs;
use std::path::PathBuf;
use structopt::{
clap::{AppSettings, ArgGroup},
StructOpt,
};
use structopt::{clap::AppSettings, StructOpt};
use target_lexicon::Triple;
use wasmtime::Engine;
@@ -42,10 +39,6 @@ lazy_static::lazy_static! {
name = "compile",
version = env!("CARGO_PKG_VERSION"),
setting = AppSettings::ColoredHelp,
group = ArgGroup::with_name("x64").multiple(true),
group = ArgGroup::with_name("preset-x64"),
group = ArgGroup::with_name("aarch64").multiple(true).conflicts_with_all(&["x64", "preset-x64"]),
group = ArgGroup::with_name("preset-aarch64").conflicts_with_all(&["x64", "preset-x64"]),
after_help = AFTER_HELP.as_str()
)]
pub struct CompileCommand {