T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

x64: fix CvtFloatToUintSeq: do not clobber src. (#4842)

Browse Source 
This slipped through the regalloc2 operand code update in #4811: the
CvtFloatToUintSeq pseudo-instruction actually clobbers its source. It
was marked as a "mod" operand in the original and I mistakenly
converted it to a "use" as I had not seen the actual clobber. The
instruction now takes an extra temp and makes a copy of `src` in the
appropriate place.

Fixes #4840.
This commit is contained in:
Chris Fallin
2022-09-01 15:46:57 -07:00
committed by GitHub
parent 08e7a7f1a0
commit 385bd0cbf8
5 changed files with 51 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
cranelift/filetests/filetests/isa/x64/fcvt.clif
View File

@@ -209,7 +209,7 @@ block0(v0: f32):
; pushq %rbp
; movq %rsp, %rbp
; block0:
; cvt_float32_to_uint32_seq %xmm0, %eax, %r8, %xmm4
; cvt_float32_to_uint32_seq %xmm0, %eax, %r9, %xmm4, %xmm5
; movq %rbp, %rsp
; popq %rbp
; ret
@@ -223,7 +223,7 @@ block0(v0: f32):
; pushq %rbp
; movq %rsp, %rbp
; block0:
; cvt_float32_to_uint64_seq %xmm0, %rax, %r8, %xmm4
; cvt_float32_to_uint64_seq %xmm0, %rax, %r9, %xmm4, %xmm5
; movq %rbp, %rsp
; popq %rbp
; ret
@@ -237,7 +237,7 @@ block0(v0: f64):
; pushq %rbp
; movq %rsp, %rbp
; block0:
; cvt_float64_to_uint32_seq %xmm0, %eax, %r8, %xmm4
; cvt_float64_to_uint32_seq %xmm0, %eax, %r9, %xmm4, %xmm5
; movq %rbp, %rsp
; popq %rbp
; ret
@@ -251,7 +251,7 @@ block0(v0: f64):
; pushq %rbp
; movq %rsp, %rbp
; block0:
; cvt_float64_to_uint64_seq %xmm0, %rax, %r8, %xmm4
; cvt_float64_to_uint64_seq %xmm0, %rax, %r9, %xmm4, %xmm5
; movq %rbp, %rsp
; popq %rbp
; ret
@@ -265,7 +265,7 @@ block0(v0: f32):
; pushq %rbp
; movq %rsp, %rbp
; block0:
; cvt_float32_to_uint32_sat_seq %xmm0, %eax, %r8, %xmm4
; cvt_float32_to_uint32_sat_seq %xmm0, %eax, %r9, %xmm4, %xmm5
; movq %rbp, %rsp
; popq %rbp
; ret
@@ -279,7 +279,7 @@ block0(v0: f32):
; pushq %rbp
; movq %rsp, %rbp
; block0:
; cvt_float32_to_uint64_sat_seq %xmm0, %rax, %r8, %xmm4
; cvt_float32_to_uint64_sat_seq %xmm0, %rax, %r9, %xmm4, %xmm5
; movq %rbp, %rsp
; popq %rbp
; ret
@@ -293,7 +293,7 @@ block0(v0: f64):
; pushq %rbp
; movq %rsp, %rbp
; block0:
; cvt_float64_to_uint32_sat_seq %xmm0, %eax, %r8, %xmm4
; cvt_float64_to_uint32_sat_seq %xmm0, %eax, %r9, %xmm4, %xmm5
; movq %rbp, %rsp
; popq %rbp
; ret
@@ -307,7 +307,7 @@ block0(v0: f64):
; pushq %rbp
; movq %rsp, %rbp
; block0:
; cvt_float64_to_uint64_sat_seq %xmm0, %rax, %r8, %xmm4
; cvt_float64_to_uint64_sat_seq %xmm0, %rax, %r9, %xmm4, %xmm5
; movq %rbp, %rsp
; popq %rbp
; ret