T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Switch DataValue to use Ieee32/Ieee64

Browse Source 
As discussed in #2251, in order to be very confident that NaN signaling bits are correctly handled by the compiler, this switches `DataValue` to use Cranelift's `Ieee32` and `Ieee64` structures. This makes it a bit more inconvenient to interpreter Cranelift FP operations but this should change to something like `rustc_apfloat` in the future.
This commit is contained in:
Andrew Brown
2020-10-07 09:57:51 -07:00
parent ce44719e1f
commit 3778fa025c
5 changed files with 22 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
cranelift/interpreter/src/interpreter.rs
View File

@@ -12,7 +12,7 @@ use cranelift_codegen::ir::{
Value as ValueRef, ValueList,
};
use log::trace;
use std::ops::{Add, Div, Mul, Sub};
use std::ops::{Add, Mul, Sub};
use thiserror::Error;
/// The valid control flow states.
@@ -153,10 +153,11 @@ impl Interpreter {
Iadd => binary_op!(Add::add[arg1, arg2]; [I8, I16, I32, I64]; inst),
Isub => binary_op!(Sub::sub[arg1, arg2]; [I8, I16, I32, I64]; inst),
Imul => binary_op!(Mul::mul[arg1, arg2]; [I8, I16, I32, I64]; inst),
Fadd => binary_op!(Add::add[arg1, arg2]; [F32, F64]; inst),
Fsub => binary_op!(Sub::sub[arg1, arg2]; [F32, F64]; inst),
Fmul => binary_op!(Mul::mul[arg1, arg2]; [F32, F64]; inst),
Fdiv => binary_op!(Div::div[arg1, arg2]; [F32, F64]; inst),
// TODO re-enable by importing something like rustc_apfloat for correctness.
// Fadd => binary_op!(Add::add[arg1, arg2]; [F32, F64]; inst),
// Fsub => binary_op!(Sub::sub[arg1, arg2]; [F32, F64]; inst),
// Fmul => binary_op!(Mul::mul[arg1, arg2]; [F32, F64]; inst),
// Fdiv => binary_op!(Div::div[arg1, arg2]; [F32, F64]; inst),
_ => unimplemented!("interpreter does not support opcode yet: {}", opcode),
}?;
frame.set(first_result(frame.function, inst), result);