T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

wig: alex has convinced me that this BorrowChecker creation is correct

Browse Source
This commit is contained in:
Pat Hickey
2020-05-20 12:29:00 -07:00
parent b130a64d19
commit 37514b730f
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
crates/wasi-common/wig/src/wasi.rs
View File

@@ -468,12 +468,10 @@ pub fn define_struct_for_wiggle(args: TokenStream) -> TokenStream {
} }
}; };
let mem: WasiMemory = mem.into(); let mem: WasiMemory = mem.into();
// FIXME: // Wiggle does not expose any methods for functions to re-enter the
// Currently, none of the wasi-common functions will re-enter the guest, so // WebAssembly module, or expose the memory via non-wiggle mechanisms.
// creating a BorrowChecker here ensures there is just one per the // Therefore, creating a new BorrowChecker at the root of each function
// WebAssembly memory. I'd like a wasmtime expert to show me how to // invocation is correct.
// create a BorrowChecker once per Store, and access it in this
// context, though.
let bc = wiggle::BorrowChecker::new(); let bc = wiggle::BorrowChecker::new();
wasi_common::wasi::#module_id::#name_ident( wasi_common::wasi::#module_id::#name_ident(
&mut my_cx.borrow_mut(), &mut my_cx.borrow_mut(),