From 354daf5b932319398a9671a9e86bd4606e71a651 Mon Sep 17 00:00:00 2001 From: Andrew Brown Date: Wed, 10 Aug 2022 09:47:02 -0700 Subject: [PATCH] [fuzz] Fix issues with single-inst module generator (#4674) * [fuzz] Fix signature of `i64.extend32_s` single-instruction test This single-instruction test incorrectly attempted to convert an `i32` to an `i64`; the correct signature is `i64 -> i64`. See the [WebAssembly specification](https://webassembly.github.io/spec/core/bikeshed/#a7-index-of-instructions). * [fuzz] Fix typo in single-instruction function generator Previously, the `unary!` macro created functions that used two operands instead of the expected one. --- crates/fuzzing/src/generators/single_inst_module.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/fuzzing/src/generators/single_inst_module.rs b/crates/fuzzing/src/generators/single_inst_module.rs index 1d860d7acd..5f619ca16a 100644 --- a/crates/fuzzing/src/generators/single_inst_module.rs +++ b/crates/fuzzing/src/generators/single_inst_module.rs @@ -111,7 +111,7 @@ macro_rules! compare { macro_rules! unary { ($inst:ident, $rust_ty:tt) => { - binary! { $inst, valtype!($rust_ty), valtype!($rust_ty) } + unary! { $inst, valtype!($rust_ty), valtype!($rust_ty) } }; ($inst:ident, $argument_ty:expr, $result_ty:expr) => { SingleInstModule { @@ -241,7 +241,7 @@ static INSTRUCTIONS: &[SingleInstModule] = &[ unary!(I32Extend16S, i32), unary!(I64Extend8S, i64), unary!(I64Extend16S, i64), - convert!(I64Extend32S, i32 -> i64), + convert!(I64Extend32S, i64 -> i64), convert!(I32WrapI64, i64 -> i32), convert!(I64ExtendI32S, i32 -> i64), convert!(I64ExtendI32U, i32 -> i64),