Merge pull request from GHSA-wh6w-3828-g9qf
* Unconditionally use `MemoryImageSlot` This commit removes the internal branching within the pooling instance allocator to sometimes use a `MemoryImageSlot` and sometimes now. Instead this is now unconditionally used in all situations on all platforms. This fixes an issue where the state of a slot could get corrupted if modules being instantiated switched from having images to not having an image or vice versa. The bulk of this commit is the removal of the `memory-init-cow` compile-time feature in addition to adding Windows support to the `cow.rs` file. * Fix compile on Unix * Add a stricter assertion for static memory bounds Double-check that when a memory is allocated the configuration required is satisfied by the pooling allocator.
This commit is contained in:
@@ -62,7 +62,6 @@ default = [
|
||||
'parallel-compilation',
|
||||
'cranelift',
|
||||
'pooling-allocator',
|
||||
'memory-init-cow',
|
||||
'vtune',
|
||||
]
|
||||
|
||||
@@ -104,13 +103,6 @@ all-arch = ["wasmtime-cranelift?/all-arch"]
|
||||
# need portable signal handling.
|
||||
posix-signals-on-macos = ["wasmtime-runtime/posix-signals-on-macos"]
|
||||
|
||||
# Enables, on supported platforms, the usage of copy-on-write initialization of
|
||||
# compatible linear memories. For more information see the documentation of
|
||||
# `Config::memory_init_cow`.
|
||||
#
|
||||
# Enabling this feature has no effect on unsupported platforms.
|
||||
memory-init-cow = ["wasmtime-runtime/memory-init-cow"]
|
||||
|
||||
# Enables in-progress support for the component model. Note that this feature is
|
||||
# in-progress, buggy, and incomplete. This is primarily here for internal
|
||||
# testing purposes.
|
||||
|
||||
Reference in New Issue
Block a user