T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove xmm_r_r inst data structure and cases after related refactoring

Browse Source 
Removes unneeded data structure that was holding instructions for
xmm based move instructions. These instructions can should be categorized
as rm not just r. This change is intended to simplify organization and
cases when lowering.
This commit is contained in:
Johnnie Birch
2020-06-06 16:20:08 -07:00
committed by Benjamin Bouvier
parent f2f7706265
commit 2d364f75bd
6 changed files with 23 additions and 83 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
cranelift/codegen/src/isa/x64/abi.rs
View File

@@ -280,7 +280,11 @@ impl ABIBody for X64ABIBody {
return Inst::mov_r_r(/*is64=*/ true, from_reg.to_reg(), to_reg);
} else if from_reg.get_class() == RegClass::V128 {
// TODO: How to support Movss. Should is64 always be true?
return Inst::xmm_r_r(SseOpcode::Movsd, from_reg.to_reg(), to_reg);
return Inst::xmm_mov_rm_r(
SseOpcode::Movsd,
RegMem::reg(from_reg.to_reg()),
to_reg,
);
}
unimplemented!("moving from non-int arg to vreg {:?}", from_reg.get_class());
}
@@ -316,9 +320,9 @@ impl ABIBody for X64ABIBody {
Writable::<Reg>::from_reg(to_reg.to_reg()),
))
} else if to_reg.get_class() == RegClass::V128 {
ret.push(Inst::xmm_r_r(
ret.push(Inst::xmm_mov_rm_r(
SseOpcode::Movsd,
from_reg.to_reg(),
RegMem::reg(from_reg.to_reg()),
Writable::<Reg>::from_reg(to_reg.to_reg()),
))
} else {