From 28cfa575339f8ad1552af254077a1fde1962d750 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sa=C3=BAl=20Cabrera?= Date: Mon, 5 Dec 2022 19:46:58 -0500 Subject: [PATCH] cranelift: Small documentation fixes (#5377) * `translate_operator` doesn't return a boolean. * `from_base_offset` doesn't panic if offset is smaller than base. --- cranelift/codegen/src/ir/sourceloc.rs | 4 ---- cranelift/wasm/src/code_translator.rs | 3 +-- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/cranelift/codegen/src/ir/sourceloc.rs b/cranelift/codegen/src/ir/sourceloc.rs index 21f7da5ab5..53331ee8c6 100644 --- a/cranelift/codegen/src/ir/sourceloc.rs +++ b/cranelift/codegen/src/ir/sourceloc.rs @@ -63,10 +63,6 @@ impl RelSourceLoc { } /// Creates a new `RelSourceLoc` based on the given base and offset. - /// - /// # Panics - /// - /// Panics if the offset is smaller than the base. pub fn from_base_offset(base: SourceLoc, offset: SourceLoc) -> Self { if base.is_default() || offset.is_default() { Self::default() diff --git a/cranelift/wasm/src/code_translator.rs b/cranelift/wasm/src/code_translator.rs index c75f6fe863..e381825d8f 100644 --- a/cranelift/wasm/src/code_translator.rs +++ b/cranelift/wasm/src/code_translator.rs @@ -100,8 +100,7 @@ use wasmparser::{FuncValidator, MemArg, Operator, WasmModuleResources}; feature = "cargo-clippy", allow(clippy::unneeded_field_pattern, clippy::cognitive_complexity) )] -/// Translates wasm operators into Cranelift IR instructions. Returns `true` if it inserted -/// a return. +/// Translates wasm operators into Cranelift IR instructions. pub fn translate_operator( validator: &mut FuncValidator, op: &Operator,