Allow failures when uploading release artifacts (#3832)

Looks like the 0.34.1 release is missing artifacts and some jobs
building artifacts ended up being cancelled because of API rate limits
being hit on the builders. Artifacts are uploaded to the job, however,
which means we can always go back and grab them to upload them, unless
the whole job was cancelled. For 0.34.1 it looks like the Linux builder
hit an error but its error then subsequently cancelled the Windows
builders, so we don't actually have artifacts for Windows for the 0.34.1
release. This will hopefully prevent this from causing further issues in
the future where if one builder hits an error while uploading artifacts
the others will continue and we can manually upload what's missing if
necessary.

cc #3812
This commit is contained in:
Alex Crichton
2022-02-22 10:47:15 -06:00
committed by GitHub
parent c183e93b80
commit 2616c28957

View File

@@ -439,7 +439,8 @@ jobs:
# ... and if this was an actual push (tag or `main`) then we publish a
# new release. This'll automatically publish a tag release or update `dev`
# with this `sha`
# with this `sha`. Note that `continue-on-error` is set here so if this hits
# a bug we can go back and fetch and upload the release ourselves.
- run: cd .github/actions/github-release && npm install --production
- name: Publish Release
uses: ./.github/actions/github-release
@@ -447,6 +448,7 @@ jobs:
with:
files: "dist/*"
token: ${{ secrets.GITHUB_TOKEN }}
continue-on-error: true
verify-publish:
runs-on: ubuntu-latest