T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

rename the pointer read/write methods to read and write

Browse Source 
these names were artifacts of some early confusion / bad design i made
in the traits. read and write are much simpler names!

also, change a ptr_mut to ptr where we just read the contents in the
argument marshalling for structs. this has no effect, but it is more
correct.
This commit is contained in:
Pat Hickey
2020-02-26 10:44:04 -08:00
committed by Jakub Konka
parent c8ea27553d
commit 25a411d7fd
6 changed files with 14 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
crates/generate/src/funcs.rs
View File

@@ -262,8 +262,8 @@ fn marshal_arg(
let arg_name = names.func_ptr_binding(&param.name);
let name = names.func_param(&param.name);
quote! {
let #name = match memory.ptr_mut::<#pointee_type>(#arg_name as u32) {
Ok(p) => match p.read_ptr_from_guest() {
let #name = match memory.ptr::<#pointee_type>(#arg_name as u32) {
Ok(p) => match p.read() {
Ok(r) => r,
Err(e) => {
#error_handling
@@ -335,7 +335,7 @@ where
// trait binding returns func_param name.
let val_name = names.func_param(&result.name);
let post = quote! {
#ptr_name.write_ptr_to_guest(&#val_name);
#ptr_name.write(&#val_name);
};
(pre, post)
};