diff --git a/crates/test-programs/wasi-tests/src/bin/fd_readdir.rs b/crates/test-programs/wasi-tests/src/bin/fd_readdir.rs index 903329b744..6a53a8ed11 100644 --- a/crates/test-programs/wasi-tests/src/bin/fd_readdir.rs +++ b/crates/test-programs/wasi-tests/src/bin/fd_readdir.rs @@ -1,5 +1,5 @@ use more_asserts::assert_gt; -use std::{cmp::min, env, mem, process, slice, str}; +use std::{env, mem, process, slice, str}; use wasi_tests::open_scratch_directory; const BUF_LEN: usize = 256; @@ -59,7 +59,9 @@ unsafe fn exec_fd_readdir(fd: wasi::Fd, cookie: wasi::Dircookie) -> (Vec = ReadDir::from_slice(sl).collect(); let eof = bufused < BUF_LEN; (dirs, eof) diff --git a/crates/wasi-common/src/snapshots/wasi_snapshot_preview1.rs b/crates/wasi-common/src/snapshots/wasi_snapshot_preview1.rs index 794be79c9f..7dc6c03ae7 100644 --- a/crates/wasi-common/src/snapshots/wasi_snapshot_preview1.rs +++ b/crates/wasi-common/src/snapshots/wasi_snapshot_preview1.rs @@ -304,7 +304,6 @@ impl<'a> WasiSnapshotPreview1 for WasiCtx { let dirent_len: types::Size = dirent_raw.len().try_into()?; let name_raw = name.as_bytes(); let name_len = name_raw.len().try_into()?; - let offset = dirent_len.checked_add(name_len).ok_or(Error::Overflow)?; // Copy as many bytes of the dirent as we can, up to the end of the buffer. let dirent_copy_len = min(dirent_len, buf_len - bufused); @@ -318,6 +317,7 @@ impl<'a> WasiSnapshotPreview1 for WasiCtx { } buf = buf.add(dirent_copy_len)?; + bufused += dirent_copy_len; // Copy as many bytes of the name as we can, up to the end of the buffer. let name_copy_len = min(name_len, buf_len - bufused); @@ -331,8 +331,7 @@ impl<'a> WasiSnapshotPreview1 for WasiCtx { } buf = buf.add(name_copy_len)?; - - bufused += offset; + bufused += name_copy_len; } Ok(bufused)