T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

readlink: get rid of weird partial-buffer semantics carried over from posix

Browse Source 
but follow posix in returning ERANGE when the result is too big
This commit is contained in:
Pat Hickey
2021-01-04 16:41:24 -08:00
parent 84318024ef
commit 222a57868e
5 changed files with 14 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
crates/test-programs/wasi-tests/src/bin/readlink.rs
View File

@@ -10,7 +10,7 @@ unsafe fn test_readlink(dir_fd: wasi::Fd) {
// Read link into the buffer
let buf = &mut [0u8; 10];
let mut bufused = wasi::path_readlink(dir_fd, "symlink", buf.as_mut_ptr(), buf.len())
let bufused = wasi::path_readlink(dir_fd, "symlink", buf.as_mut_ptr(), buf.len())
.expect("readlink should succeed");
assert_eq!(bufused, 6, "should use 6 bytes of the buffer");
assert_eq!(&buf[..6], b"target", "buffer should contain 'target'");
@@ -22,10 +22,14 @@ unsafe fn test_readlink(dir_fd: wasi::Fd) {
// Read link into smaller buffer than the actual link's length
let buf = &mut [0u8; 4];
bufused = wasi::path_readlink(dir_fd, "symlink", buf.as_mut_ptr(), buf.len())
.expect("readlink should succeed");
assert_eq!(bufused, 4, "should use all 4 bytes of the buffer");
assert_eq!(buf, b"targ", "buffer should contain 'targ'");
let err = wasi::path_readlink(dir_fd, "symlink", buf.as_mut_ptr(), buf.len())
.err()
.expect("readlink with too-small buffer should fail");
assert_eq!(
err.raw_error(),
wasi::ERRNO_RANGE,
"readlink with too-small buffer should give ERANGE"
);
// Clean up.
wasi::path_unlink_file(dir_fd, "target").expect("removing a file");