[machinst x64]: rename Inst::XmmUninitializedValue and document

This approach is not the best but avoids an extra instruction; perhaps at some point, as mentioned in https://github.com/bytecodealliance/wasmtime/pull/2248, we will add the extra instruction or refactor things in such a way that this `Inst` variant is unnecessary.
This commit is contained in:
Andrew Brown
2020-10-01 11:39:12 -07:00
parent 3d9f3bf728
commit 16a2538ecd
4 changed files with 26 additions and 16 deletions

View File

@@ -2995,7 +2995,7 @@ fn lower_insn_to_regs<C: LowerCtx<I = Inst>>(
// We know that splat will overwrite all of the lanes of `dst` but it takes several
// instructions to do so. Because of the multiple instructions, there is no good way to
// declare `dst` a `def` except with the following pseudo-instruction.
ctx.emit(Inst::xmm_fake_def(dst));
ctx.emit(Inst::xmm_uninit_value(dst));
match ty.lane_bits() {
8 => {
emit_insert_lane(ctx, src, dst, 0, ty.lane_type());