Enable a few more clippy lints.

lib/codegen/meta/gen_instr.py

@@ -631,7 +631,7 @@ def gen_member_inits(iform, fmt):
     # Immediate operands.
     # We have local variables with the same names as the members.
     for f in iform.imm_fields:
-        fmt.line('{}: {},'.format(f.member, f.member))
+        fmt.line('{},'.format(f.member))
 
     # Value operands.
     if iform.has_value_list:

lib/codegen/src/lib.rs

@@ -5,8 +5,6 @@
 #![cfg_attr(feature = "std", warn(unstable_features))]
 #![cfg_attr(feature = "clippy", plugin(clippy(conf_file = "../../clippy.toml")))]
 #![cfg_attr(feature="cargo-clippy", allow(
-// Rustfmt 0.9.0 is at odds with this lint:
-                block_in_if_condition_stmt,
 // Produces only a false positive:
                 while_let_loop,
 // Produces many false positives, but did produce some valid lints, now fixed:
@@ -28,8 +26,6 @@
                 new_without_default,
                 new_without_default_derive,
                 should_implement_trait,
-                redundant_field_names,
-                useless_let_if_seq,
                 len_without_is_empty))]
 #![cfg_attr(
     feature = "cargo-clippy",

lib/codegen/src/postopt.rs

@@ -188,13 +188,13 @@ fn optimize_complex_addresses(pos: &mut EncCursor, inst: Inst, isa: &TargetIsa)
             flags,
             offset,
         } => MemOpInfo {
-            opcode: opcode,
+            opcode,
-            inst: inst,
+            inst,
             itype: pos.func.dfg.ctrl_typevar(inst),
-            arg: arg,
+            arg,
             st_arg: None,
-            flags: flags,
+            flags,
-            offset: offset,
+            offset,
             add_args: None,
         },
         InstructionData::Store {
@@ -203,13 +203,13 @@ fn optimize_complex_addresses(pos: &mut EncCursor, inst: Inst, isa: &TargetIsa)
             flags,
             offset,
         } => MemOpInfo {
-            opcode: opcode,
+            opcode,
-            inst: inst,
+            inst,
             itype: pos.func.dfg.ctrl_typevar(inst),
             arg: args[1],
             st_arg: Some(args[0]),
-            flags: flags,
+            flags,
-            offset: offset,
+            offset,
             add_args: None,
         },
         _ => return,

lib/filetests/src/lib.rs

@@ -6,9 +6,7 @@
 #![deny(missing_docs, trivial_numeric_casts, unused_extern_crates)]
 #![warn(unused_import_braces, unstable_features)]
 #![cfg_attr(feature="cargo-clippy", allow(
-        type_complexity,
+        type_complexity))]
-// Rustfmt 0.9.0 is at odds with this lint:
-        block_in_if_condition_stmt))]
 #![cfg_attr(
     feature = "cargo-clippy",
     warn(