Don't try to report file size or timestamps for stdio streams. (#4531)
* Don't try to report file size or timestamps for stdio streams. Calling `File::metadata()` on a stdio stream handle fails on Windows, where the stdio streams are not files. This `File::metadata()` call was effectively only being used to add file size and timestamps to the result of `filestat_get`. It's common for users to redirect stdio streams to interesting places, and applications generally shouldn't change their behavior depending on the size or timestamps of the file, if the streams are redirected to a file, so just leave these fields to 0, which is commonly understood to represent "unknown". Fixes #4497.
This commit is contained in:
25
crates/test-programs/wasi-tests/src/bin/fd_filestat_get.rs
Normal file
25
crates/test-programs/wasi-tests/src/bin/fd_filestat_get.rs
Normal file
@@ -0,0 +1,25 @@
|
||||
unsafe fn test_fd_filestat_get() {
|
||||
|
||||
let stat = wasi::fd_filestat_get(libc::STDIN_FILENO as u32).expect("failed filestat 0");
|
||||
assert_eq!(stat.size, 0, "stdio size should be 0");
|
||||
assert_eq!(stat.atim, 0, "stdio atim should be 0");
|
||||
assert_eq!(stat.mtim, 0, "stdio mtim should be 0");
|
||||
assert_eq!(stat.ctim, 0, "stdio ctim should be 0");
|
||||
|
||||
let stat = wasi::fd_filestat_get(libc::STDOUT_FILENO as u32).expect("failed filestat 1");
|
||||
assert_eq!(stat.size, 0, "stdio size should be 0");
|
||||
assert_eq!(stat.atim, 0, "stdio atim should be 0");
|
||||
assert_eq!(stat.mtim, 0, "stdio mtim should be 0");
|
||||
assert_eq!(stat.ctim, 0, "stdio ctim should be 0");
|
||||
|
||||
let stat = wasi::fd_filestat_get(libc::STDERR_FILENO as u32).expect("failed filestat 2");
|
||||
assert_eq!(stat.size, 0, "stdio size should be 0");
|
||||
assert_eq!(stat.atim, 0, "stdio atim should be 0");
|
||||
assert_eq!(stat.mtim, 0, "stdio mtim should be 0");
|
||||
assert_eq!(stat.ctim, 0, "stdio ctim should be 0");
|
||||
}
|
||||
|
||||
fn main() {
|
||||
// Run the tests.
|
||||
unsafe { test_fd_filestat_get() }
|
||||
}
|
||||
Reference in New Issue
Block a user