another one bites the dust

This commit is contained in:
Pat Hickey
2021-01-28 12:35:13 -08:00
parent 79e8f17486
commit 0cedc17246

View File

@@ -1,8 +1,8 @@
use std::{env, process}; use std::{env, process};
use wasi_tests::{assert_errno, create_file, open_scratch_directory}; use wasi_tests::{assert_errno, create_file, open_scratch_directory, TESTCONFIG};
unsafe fn test_path_symlink_trailing_slashes(dir_fd: wasi::Fd) { unsafe fn test_path_symlink_trailing_slashes(dir_fd: wasi::Fd) {
// XXX following section invalid on windows because its a dangling symlink if TESTCONFIG.support_dangling_symlinks() {
// Dangling symlink: Link destination shouldn't end with a slash. // Dangling symlink: Link destination shouldn't end with a slash.
assert_errno!( assert_errno!(
wasi::path_symlink("source", dir_fd, "target/") wasi::path_symlink("source", dir_fd, "target/")
@@ -12,54 +12,54 @@ unsafe fn test_path_symlink_trailing_slashes(dir_fd: wasi::Fd) {
); );
// Dangling symlink: Without the trailing slash, this should succeed. // Dangling symlink: Without the trailing slash, this should succeed.
wasi::path_symlink("source", dir_fd, "target").expect("link destination ending with a slash"); wasi::path_symlink("source", dir_fd, "target")
.expect("link destination ending with a slash");
wasi::path_unlink_file(dir_fd, "target").expect("removing a file"); wasi::path_unlink_file(dir_fd, "target").expect("removing a file");
}
// Link destination already exists, target has trailing slash. // Link destination already exists, target has trailing slash.
wasi::path_create_directory(dir_fd, "target").expect("creating a directory"); wasi::path_create_directory(dir_fd, "target").expect("creating a directory");
// XXX windows gives NOENT
assert_errno!( assert_errno!(
wasi::path_symlink("source", dir_fd, "target/") wasi::path_symlink("source", dir_fd, "target/")
.expect_err("link destination already exists") .expect_err("link destination already exists")
.raw_error(), .raw_error(),
windows => wasi::ERRNO_NOENT, unix => wasi::ERRNO_EXIST,
wasi::ERRNO_EXIST windows => wasi::ERRNO_NOENT
); );
wasi::path_remove_directory(dir_fd, "target").expect("removing a directory"); wasi::path_remove_directory(dir_fd, "target").expect("removing a directory");
// Link destination already exists, target has no trailing slash. // Link destination already exists, target has no trailing slash.
wasi::path_create_directory(dir_fd, "target").expect("creating a directory"); wasi::path_create_directory(dir_fd, "target").expect("creating a directory");
// XXX windows gives NOENT
assert_errno!( assert_errno!(
wasi::path_symlink("source", dir_fd, "target") wasi::path_symlink("source", dir_fd, "target")
.expect_err("link destination already exists") .expect_err("link destination already exists")
.raw_error(), .raw_error(),
wasi::ERRNO_EXIST unix => wasi::ERRNO_EXIST,
windows => wasi::ERRNO_NOENT
); );
wasi::path_remove_directory(dir_fd, "target").expect("removing a directory"); wasi::path_remove_directory(dir_fd, "target").expect("removing a directory");
// Link destination already exists, target has trailing slash. // Link destination already exists, target has trailing slash.
create_file(dir_fd, "target"); create_file(dir_fd, "target");
// XXX windows gives NOENT
assert_errno!( assert_errno!(
wasi::path_symlink("source", dir_fd, "target/") wasi::path_symlink("source", dir_fd, "target/")
.expect_err("link destination already exists") .expect_err("link destination already exists")
.raw_error(), .raw_error(),
wasi::ERRNO_EXIST, unix => wasi::ERRNO_NOTDIR,
wasi::ERRNO_NOTDIR windows => wasi::ERRNO_NOENT
); );
wasi::path_unlink_file(dir_fd, "target").expect("removing a file"); wasi::path_unlink_file(dir_fd, "target").expect("removing a file");
// Link destination already exists, target has no trailing slash. // Link destination already exists, target has no trailing slash.
create_file(dir_fd, "target"); create_file(dir_fd, "target");
// XXX windows gives NOENT
assert_errno!( assert_errno!(
wasi::path_symlink("source", dir_fd, "target") wasi::path_symlink("source", dir_fd, "target")
.expect_err("link destination already exists") .expect_err("link destination already exists")
.raw_error(), .raw_error(),
wasi::ERRNO_EXIST unix => wasi::ERRNO_EXIST,
windows => wasi::ERRNO_NOENT
); );
wasi::path_unlink_file(dir_fd, "target").expect("removing a file"); wasi::path_unlink_file(dir_fd, "target").expect("removing a file");
} }