T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove assertions from the hot value_def() function.

Browse Source 
The errors caught by these assertions are also detected by the IL
verifier.

Speed up compilation by 13%.
This commit is contained in:
Jakob Stoklund Olesen
2018-01-22 11:31:21 -08:00
parent c6bb7afa07
commit 085e228358
1 changed files with 2 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
lib/cretonne/src/ir/dfg.rs
View File

@@ -164,24 +164,8 @@ impl DataFlowGraph {
/// parameter. /// parameter.
pub fn value_def(&self, v: Value) -> ValueDef { pub fn value_def(&self, v: Value) -> ValueDef {
match self.values[v] { match self.values[v] {
ValueData::Inst { inst, num, .. } => { ValueData::Inst { inst, num, .. } => ValueDef::Result(inst, num as usize),
assert_eq!( ValueData::Param { ebb, num, .. } => ValueDef::Param(ebb, num as usize),
Some(v),
self.results[inst].get(num as usize, &self.value_lists),
"Dangling result value {}: {}",
v,
self.display_inst(inst, None)
);
ValueDef::Result(inst, num as usize)
}
ValueData::Param { ebb, num, .. } => {
assert_eq!(
Some(v),
self.ebbs[ebb].params.get(num as usize, &self.value_lists),
"Dangling EBB parameter value"
);
ValueDef::Param(ebb, num as usize)
}
ValueData::Alias { original, .. } => { ValueData::Alias { original, .. } => {
// Make sure we only recurse one level. `resolve_aliases` has safeguards to // Make sure we only recurse one level. `resolve_aliases` has safeguards to
// detect alias loops without overrunning the stack. // detect alias loops without overrunning the stack.