T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cranelift: Rename Interpreter overflow method

Browse Source
This commit is contained in:
Afonso Bordado
2021-07-08 10:02:59 +01:00
committed by Andrew Brown
parent e628fb376f
commit 037bd41c67
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
cranelift/interpreter/src/step.rs
View File

@@ -720,8 +720,8 @@ where
&left.clone().convert(ValueConversionKind::ToUnsigned)?, &left.clone().convert(ValueConversionKind::ToUnsigned)?,
&right.clone().convert(ValueConversionKind::ToUnsigned)?, &right.clone().convert(ValueConversionKind::ToUnsigned)?,
)?, )?,
IntCC::Overflow => Value::of(left, right)?, IntCC::Overflow => Value::overflow(left, right)?,
IntCC::NotOverflow => !Value::of(left, right)?, IntCC::NotOverflow => !Value::overflow(left, right)?,
}) })
} }

4
cranelift/interpreter/src/value.rs
View File

@@ -37,7 +37,7 @@ pub trait Value: Clone + From<DataValue> {
Ok(other.eq(self)? || other.gt(self)?) Ok(other.eq(self)? || other.gt(self)?)
} }
fn uno(&self, other: &Self) -> ValueResult<bool>; fn uno(&self, other: &Self) -> ValueResult<bool>;
fn of(&self, other: &Self) -> ValueResult<bool>; fn overflow(&self, other: &Self) -> ValueResult<bool>;
// Arithmetic. // Arithmetic.
fn add(self, other: Self) -> ValueResult<Self>; fn add(self, other: Self) -> ValueResult<Self>;
@@ -278,7 +278,7 @@ impl Value for DataValue {
Ok(self.is_nan()? || other.is_nan()?) Ok(self.is_nan()? || other.is_nan()?)
} }
fn of(&self, other: &Self) -> ValueResult<bool> { fn overflow(&self, other: &Self) -> ValueResult<bool> {
Ok(match (self, other) { Ok(match (self, other) {
(DataValue::I8(a), DataValue::I8(b)) => a.checked_sub(*b).is_none(), (DataValue::I8(a), DataValue::I8(b)) => a.checked_sub(*b).is_none(),
(DataValue::I16(a), DataValue::I16(b)) => a.checked_sub(*b).is_none(), (DataValue::I16(a), DataValue::I16(b)) => a.checked_sub(*b).is_none(),