ISLE: remove all uses of argument polarity, and remove it from the language. (#4091)

Browse Source

This PR removes "argument polarity": the feature of ISLE extractors that lets them take
inputs aside from the value to be matched.

Cases that need this expressivity have been subsumed by #4072 with if-let clauses;
we can now finally remove this misfeature of the language, which has caused significant
confusion and has always felt like a bit of a hack.

This PR (i) removes the feature from the ISLE compiler; (ii) removes it from the reference
documentation; and (iii) refactors away all uses of the feature in our three existing
backends written in ISLE.

...

This commit is contained in:

Chris Fallin

2022-05-02 09:52:12 -07:00

committed by GitHub

parent c7e2c21bb2

commit 03793b71a7

21 changed files with 2123 additions and 2464 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

762

cranelift/codegen/src/isa/x64/lower/isle/generated_code.rs generated

File diff suppressed because it is too large Load Diff