T0b1/wasmtime
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Refactor address_transform.rs to use less memory (#1260)

Browse Source 
The crates/debug/src/transform/address_transform.rs is unoptimized in terms of data structures. This PR refactors this file to remove creation of intermediate in-heap structures, thus improves overall performance of the DWARF transformation.

* Reduce amount of memory allocated in translate_ranges_raw
* refactor translate_ranges
* Don't transform non-unit .debug_line
* type annotation for TransformRangeXXXIter's
* Fix empty generated wasm positions
This commit is contained in:
Yury Delendik
2020-03-23 16:36:29 -05:00
committed by GitHub
parent 2fdc7f1a8e
commit 021ebb3748
4 changed files with 233 additions and 89 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
crates/debug/src/transform/range_info_builder.rs
View File

@@ -131,13 +131,7 @@ impl RangeInfoBuilder {
RangeInfoBuilder::Ranges(ranges) => {
let mut result = Vec::new();
for (begin, end) in ranges {
for tr in addr_tr.translate_ranges(*begin, *end) {
if tr.1 == 0 {
// Ignore empty range
continue;
}
result.push(tr);
}
result.extend(addr_tr.translate_ranges(*begin, *end));
}
if result.len() != 1 {
let range_list = result
@@ -200,16 +194,12 @@ impl RangeInfoBuilder {
let mut range_list = Vec::new();
for (begin, end) in ranges {
assert_lt!(begin, end);
for tr in addr_tr.translate_ranges(*begin, *end) {
if tr.1 == 0 {
// Ignore empty range
continue;
}
range_list.push(write::Range::StartLength {
range_list.extend(addr_tr.translate_ranges(*begin, *end).map(|tr| {
write::Range::StartLength {
begin: tr.0,
length: tr.1,
});
}
}
}));
}
out_range_lists.add(write::RangeList(range_list))
} else {