T0b1/regalloc2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use drain instead of clear (#123)

Browse Source
This commit is contained in:
Trevor Elliott
2023-04-06 14:21:42 -07:00
committed by GitHub
parent 9c6d6dc9aa
commit f0e9cde328
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/ion/redundant_moves.rs
View File

@@ -111,9 +111,9 @@ impl RedundantMoveEliminator {
pub fn clear_alloc(&mut self, alloc: Allocation) { pub fn clear_alloc(&mut self, alloc: Allocation) {
trace!(" redundant move eliminator: clear {:?}", alloc); trace!(" redundant move eliminator: clear {:?}", alloc);
if let Some(ref mut existing_copies) = self.reverse_allocs.get_mut(&alloc) { if let Some(ref mut existing_copies) = self.reverse_allocs.get_mut(&alloc) {
for to_inval in existing_copies.iter() { for to_inval in existing_copies.drain(..) {
trace!(" -> clear existing copy: {:?}", to_inval); trace!(" -> clear existing copy: {:?}", to_inval);
if let Some(val) = self.allocs.get_mut(to_inval) { if let Some(val) = self.allocs.get_mut(&to_inval) {
match val { match val {
RedundantMoveState::Copy(_, Some(vreg)) => { RedundantMoveState::Copy(_, Some(vreg)) => {
*val = RedundantMoveState::Orig(*vreg); *val = RedundantMoveState::Orig(*vreg);
@@ -121,9 +121,8 @@ impl RedundantMoveEliminator {
_ => *val = RedundantMoveState::None, _ => *val = RedundantMoveState::None,
} }
} }
self.allocs.remove(to_inval); self.allocs.remove(&to_inval);
} }
existing_copies.clear();
} }
self.allocs.remove(&alloc); self.allocs.remove(&alloc);
} }